Frederick [Bot]
eb6663e1f5
[skip ci] Updated swagger docs
...
(cherry picked from commit 9dd95101f9b695a16c1ff755442194f54ace154b)
2024-09-20 14:26:01 +02:00
kolaente
b94802169c
fix(task): cyclomatic complexity
...
(cherry picked from commit 20724f6fb57128fd212544cb3a6b55b90f38c316)
2024-09-20 14:26:00 +02:00
kolaente
d23484c8f3
fix(project): reset id before creating
...
Resolves https://vikunja.sentry.io/share/issue/6f1e37d4b8b248188e20650234a45cde/
(cherry picked from commit 8d730543c3c7bbb8e4f3a8b18022275a35ce5330)
2024-09-20 14:25:57 +02:00
kolaente
5bfd99dd77
fix(task): specify task index when creating multiple tasks at once
...
This change allows to specify the task index when creating a task, which will then be checked to avoid duplicates and used. This allows us to calculate the indexes for all tasks beforehand when creating them at once using quick add magic.
The method is not bulletproof, but already fixes a problem where multiple tasks would have the same index when created that way.
Resolves https://community.vikunja.io/t/add-multiple-tasks-at-once/333/16
(cherry picked from commit 55dd7d298187dcc8393ae67340117d66d45dc4ef)
2024-09-20 14:25:48 +02:00
kolaente
ac87035742
fix(auth): restrict max password length to 72 bytes
...
Bcrypt allows a maximum of 72 bytes. This is part of the algorithm and not something we could change in Vikunja. The solution here was to restrict the password during registration to a max length of 72 bytes. In the future, this should be changed to hash passwords with sha512 or similar before hashing them with bcrypt. Because they should also be salted in that case and the added complexity during the migration phase, this was not implemented yet.
The change in this commit only improves the error handling to return an input error instead of a server error when the user enters a password > 72 bytes.
Resolves https://vikunja.sentry.io/share/issue/e8e0b64612d84504942feee002ac498a/
(cherry picked from commit 44a43b9f8616f11560c9e04f88f3000a6df5338d)
2024-09-20 14:25:46 +02:00
kolaente
01a7a62541
fix(caldav): reject invalid project id with error 400
...
Resolves https://vikunja.sentry.io/share/issue/6fc18edefa0e4db3b2e10efe36deeaa4/
(cherry picked from commit 1085a6583be733aa39128bde9dcb641be734870d)
2024-09-20 14:25:41 +02:00
kolaente
c5f043c346
fix(label): ignore existing ID during creation
...
(cherry picked from commit e698ac5a346785df623553104c5650566d1a9bcd)
2024-09-20 14:25:39 +02:00
Frederick [Bot]
be5822712e
[skip ci] Updated swagger docs
...
(cherry picked from commit 2539f15dfb62689137e1a68a3ca7cbb8e13ac222)
2024-09-20 14:25:27 +02:00
kolaente
a5a54a40f6
docs(api): use correct return type for the /user endpoint
...
(cherry picked from commit 5c1b2846a1c6a9ea3690ac03d58149c3715f04d4)
2024-09-20 14:25:25 +02:00
Frederick [Bot]
85445ea032
[skip ci] Updated swagger docs
...
(cherry picked from commit 2b8515b91db6f90becfe150b351120e3b1afc726)
2024-09-20 14:25:03 +02:00
kolaente
0b9f3070fd
fix(files): use absolute path everywhere
...
(cherry picked from commit 68636f27da707f3ee87ba0e4f1ff100504486608)
2024-09-20 14:25:02 +02:00
kolaente
cca02a3f2e
chore(docs): clarify usage of related model creation
...
Resolves https://github.com/go-vikunja/vikunja/issues/323
(cherry picked from commit cf94cc8cab1c438eb30e63b0b02819c503b32e20)
2024-09-20 14:25:00 +02:00
kolaente
e70f5bcce3
chore(attachments): refactor building image preview
...
(cherry picked from commit 02c1de55c4b21863bb7500811e04bc0de9177089)
2024-09-20 14:24:53 +02:00
kolaente
bf08dc2585
chore(files): use absolute file path to retrieve and save files
...
(cherry picked from commit c2b116de70df335a6a354cf2b3595632c8b49ff1)
2024-09-20 14:23:48 +02:00
kolaente
eb89f68f73
fix(caldav): make sure colors are correctly saved and returned
...
Resolves https://community.vikunja.io/t/caldav-sync-tasks-org-strips-colour-and-end-date-values/2753/2
(cherry picked from commit ffcc48ec871f50c6732eb2f2cf1a49d41e7f47fe)
2024-09-20 14:22:47 +02:00
Frederick [Bot]
08b4bcaff9
[skip ci] Updated swagger docs
...
(cherry picked from commit 5aa0b6a0cf7d8b6dc4c064b0b9c01c4ae121be34)
2024-09-20 14:22:45 +02:00
kolaente
0a29a88a26
chore(subscription): return subscription entity type using json Marshaler
...
(cherry picked from commit b60efbd259466637cd9331e5a2101eced07808e8)
2024-09-20 14:22:43 +02:00
kolaente
313b99e296
fix(reminders): notify subscribed users as well
...
Resolves https://community.vikunja.io/t/no-reminder-notification-by-e-mail-from-my-colleague/2779
(cherry picked from commit 34ac29fcceec0b9f5f0c3c9fb22c015858f357d5)
2024-09-20 14:22:41 +02:00
kolaente
95ef4e1045
fix(subscriptions): do not panic when a task does not have a subscription
...
(cherry picked from commit 75f3e930cd8072fc6709d1e653b177263d02c8ce)
2024-09-20 14:22:39 +02:00
kolaente
8b8ec19bb3
fix(subscriptions): cleanup and simplify fetching subscribers for tasks and projects logic
...
Vikunja now uses one recursive CTE and a few optimizations to fetch all subscribers for a task or project. This makes the relevant code easier to maintain and more performant.
(cherry picked from commit 4ff8815fe1bfe72e02c10f6a6877c93a630f36a4)
2024-09-20 14:22:37 +02:00
kolaente
c8f7a57566
fix(subscription): always return task subscription when subscribed to task and project
...
(cherry picked from commit 115d1c3618811560b4f2c87d764da196bafc1c06)
2024-09-20 14:22:34 +02:00
kolaente
fc8252e751
fix(subscriptions): correctly inherit subscriptions
...
Resolves https://community.vikunja.io/t/e-mail-notification-twice/2740/20
(cherry picked from commit 06305eb6b3300bf1c989e06e54766e427bcc749a)
2024-09-20 14:22:33 +02:00
kolaente
a462697b30
fix(notifications): only add project subscription as task subscription when the user is not already subscribed to the task
...
Before this fix, a project subscription object was added twice to the list of subscriptions for a task when the user did not subscribe to the task directly. This caused the user to receive a comment notification twice for a given task.
This was probably a regression from efde364224.
Resolves https://community.vikunja.io/t/e-mail-notification-twice/2740/18
(cherry picked from commit 2c9becec101c14dd744444fffe244510e8394323)
2024-09-20 14:22:29 +02:00
kolaente
5049cbf236
chore(web): always set internal error
...
(cherry picked from commit 5c56d07215a2a1fac63c565eac669fe8c1f19cbc)
2024-09-20 14:22:28 +02:00
kolaente
a2ef74cade
chore(web): use logger directly
...
(cherry picked from commit 6fb314b326d530322f1a2e674f250a265268082c)
2024-09-20 14:22:25 +02:00
kolaente
fe44b7d473
chore(web): use web auth factory directly
...
(cherry picked from commit 9b01666ec6c41f5487cfc6c381b3937f1fe53a16)
2024-09-20 14:22:23 +02:00
kolaente
5fba4ed6ef
chore(web): use config directly
...
(cherry picked from commit bcfd72c64545241b53fc8a69197cfc6a3f316d92)
2024-09-20 14:22:19 +02:00
kolaente
d885b43328
chore(web): directly use new db session
...
(cherry picked from commit 499f66b7ae4d79e4b69c90caa618f25a18173925)
2024-09-20 14:22:16 +02:00
kolaente
459c8daed6
chore(web): remove redundant use of fmt.Sprintf
...
(cherry picked from commit 8e37d5cb76ac73ac800ef32edde7cb142d22b9a0)
2024-09-20 14:22:16 +02:00
kolaente
5768648760
chore(web): use errors.As instead of type assertion
...
(cherry picked from commit 57ba073874c23772b2b80bc12be8578860e9c7ec)
2024-09-20 14:22:11 +02:00
kolaente
198b2e3b70
chore(web): remove unused echo context
...
(cherry picked from commit 329de3aab3cf0f15759ef1e20e865d3ad801d56e)
2024-09-20 14:22:11 +02:00
kolaente
be8ecb6d36
fix(labels): test error assertion
...
(cherry picked from commit 74a74b7ec719c450dd0e4fe7b404ae46807aafdb)
2024-09-20 14:22:09 +02:00
kolaente
4c73c74587
chore(web): move web handler package to Vikunja
...
(cherry picked from commit 2063da9eecf8d0980a62106a627d7f00da172138)
2024-09-20 14:22:08 +02:00
kolaente
cfa58ae599
chore(errors): always add internal error to echo error
...
(cherry picked from commit 7a7e97770c9ecc10e805069ae16c2ffa2779d2a5)
2024-09-20 14:21:18 +02:00
kolaente
39d0409f57
fix(labels): trigger task.updated event when removing a label from a task
...
(cherry picked from commit bea131cfd9dcf2c0bc726cf370c7ea2a5478b16a)
2024-09-20 14:21:16 +02:00
kolaente
7b804efbe2
feat(event): simplify dispatching task updated event from only a task id
...
(cherry picked from commit 5a0d1f1dc6430f80788ae4cfacbe7da58f704841)
2024-09-20 14:21:14 +02:00
kolaente
1a131d79f9
fix(subscriptions): ignore task subscription when the user is subscribed to the project
...
Resolves https://community.vikunja.io/t/e-mail-notification-twice/2740/12
Resolves https://github.com/go-vikunja/vikunja/issues/316
(cherry picked from commit efde364224cf744c448a5b8e069776f18652d314)
2024-09-20 14:21:11 +02:00
kolaente
a253f76060
fix(api): return 404 response when using a token and the route does not exist
...
(cherry picked from commit fde1763eefc998c45d0a1ce6e1be20df6a23e18a)
2024-09-20 14:21:09 +02:00
kolaente
c85da01294
fix(task): set done at date when moving a task to the done bucket
...
Resolves https://github.com/go-vikunja/vikunja/issues/320
(cherry picked from commit bf56311faa55146cac05dbf1ee7e02e542d22a90)
2024-09-20 14:21:06 +02:00
kolaente
7b275794dc
fix(deps): update golangci
...
(cherry picked from commit 8bfd0493b2690df65ae13cf2c2a59689555631b8)
2024-09-20 14:20:56 +02:00
kolaente
de9f686480
fix(migration): ensure project background gets exported and imported
...
(cherry picked from commit ebfd5f54d2e4644aa2076c57a9b50ed5b87deaa9)
2024-08-12 20:17:10 +02:00
kolaente
d08e9650ba
fix(migration): make sure tasks are associated to the correct view and bucket for data imported from Vikunja dump
...
This change fixes a bug where imported projects would contain the default views additionally to the ones included in the export. This also caused the tasks to not show up in the views and buckets where they should show up, the newly imported ones.
Resolves https://community.vikunja.io/t/migration-from-vikunja-export-duplicated-boards-local-to-oidc/2690
(cherry picked from commit 28b4eaee31b5e38b45357ae55a0195ebcd31c7d5)
2024-08-12 20:17:09 +02:00
kolaente
0434a96c3a
fix(views): do not create task bucket and task position entries when duplicating a project
...
Resolves https://github.com/go-vikunja/vikunja/issues/297
Resolves https://community.vikunja.io/t/duplicating-a-board-puts-the-buckets-in-the-original-board/2579
(cherry picked from commit b83448b7a6d78fea07e3e88af45a468b7d5b968b)
2024-08-12 20:17:07 +02:00
kolaente
2b9b77bef2
fix(task): move task into new kanban bucket when moving between projects
...
Resolves https://github.com/go-vikunja/vikunja/issues/290
Resolves https://community.vikunja.io/t/tasks-moved-from-one-project-to-another-do-not-show-up-in-kanban/2689
(cherry picked from commit eed783e42f3158e6a1fdd1fffcaf6b578d0caa64)
2024-08-12 20:17:05 +02:00
kolaente
950de7c954
fix(mail): do not fail testmail command when the connection could not be closed.
...
Resolves https://github.com/go-vikunja/vikunja/issues/300
(cherry picked from commit 40bb86bee59585f827752e96c87e5e8c8f81495c)
2024-08-12 20:16:54 +02:00
Dominik Pschenitschni
6e38bcf349
chore: improve error message
...
(cherry picked from commit bc5fd380e55252f360059d90b894ddbe60688d94)
2024-08-12 20:16:30 +02:00
Frederick [Bot]
3ecc81094f
[skip ci] Updated swagger docs
...
(cherry picked from commit 0984821b41f5f8c3eeddf81c4ad75df67c065d74)
2024-08-12 20:16:21 +02:00
kolaente
ef0bf3156e
fix(project): do not use project id of nil project in error
2024-07-18 16:39:30 +02:00
kolaente
bea81f83f7
fix(filters): only insert task buckets and positions when there are any
2024-07-18 15:38:29 +02:00
kolaente
12474e5be6
fix(kanban): make sure tasks which changed their done status are moved around in buckets
...
This fixes a bug where tasks which had their done status changed were not moved in the correct bucket. This affected both frontend and api. The move of the task between buckets is now correctly done in the api and frontend - with a bit of duplicated logic between the two. This could be optimized further in the future.
Resolves https://kolaente.dev/vikunja/vikunja/issues/2610
2024-07-18 12:39:29 +02:00
