ami/tl-vikunja
1
0
Fork 0
Code

fix(task): move task into new kanban bucket when moving between projects

Browse Source 
Resolves https://github.com/go-vikunja/vikunja/issues/290
Resolves https://community.vikunja.io/t/tasks-moved-from-one-project-to-another-do-not-show-up-in-kanban/2689

(cherry picked from commit eed783e42f3158e6a1fdd1fffcaf6b578d0caa64)
This commit is contained in:
kolaente 2024-08-12 15:35:37 +02:00
parent f5040ad2f4
commit 2b9b77bef2
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/models/tasks.go
View File

@ -917,12 +917,12 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
colsToUpdate = append(colsToUpdate, "index")
}
viewsWithDoneBucket := []*ProjectView{}
views := []*ProjectView{}
if (!t.isRepeating() && t.Done != ot.Done) || t.ProjectID != ot.ProjectID {
err = s.
Where("project_id = ? AND view_kind = ? AND bucket_configuration_mode = ? AND done_bucket_id != 0",
Where("project_id = ? AND view_kind = ? AND bucket_configuration_mode = ?",
t.ProjectID, ProjectViewKindKanban, BucketConfigurationModeManual).
Find(&viewsWithDoneBucket)
Find(&views)
if err != nil {
return
}
@ -930,7 +930,12 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
// When a task was moved between projects, ensure it is in the correct bucket
if t.ProjectID != ot.ProjectID {
for _, view := range viewsWithDoneBucket {
_, err = s.Where("task_id = ?", t.ID).Delete(&TaskBucket{})
if err != nil {
return err
}
for _, view := range views {
var bucketID = view.DoneBucketID
if bucketID == 0 || !t.Done {
bucketID, err = getDefaultBucketID(s, view)
@ -964,7 +969,7 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
// When a task changed its done status, make sure it is in the correct bucket
if t.ProjectID == ot.ProjectID && !t.isRepeating() && t.Done != ot.Done {
for _, view := range viewsWithDoneBucket {
for _, view := range views {
currentTaskBucket := &TaskBucket{}
_, err := s.Where("task_id = ? AND project_view_id = ?", t.ID, view.ID).
Get(currentTaskBucket)