1
0
Commit Graph

203 Commits

Author SHA1 Message Date
1049b27d37 fix(view): correctly resolve bucket filter when paginating
(cherry picked from commit 45ff5907e69b24f00926841790d0f4f3d11e530a)
2024-09-20 14:26:34 +02:00
b94802169c fix(task): cyclomatic complexity
(cherry picked from commit 20724f6fb57128fd212544cb3a6b55b90f38c316)
2024-09-20 14:26:00 +02:00
5bfd99dd77 fix(task): specify task index when creating multiple tasks at once
This change allows to specify the task index when creating a task, which will then be checked to avoid duplicates and used. This allows us to calculate the indexes for all tasks beforehand when creating them at once using quick add magic.
The method is not bulletproof, but already fixes a problem where multiple tasks would have the same index when created that way.

Resolves https://community.vikunja.io/t/add-multiple-tasks-at-once/333/16

(cherry picked from commit 55dd7d298187dcc8393ae67340117d66d45dc4ef)
2024-09-20 14:25:48 +02:00
0b9f3070fd fix(files): use absolute path everywhere
(cherry picked from commit 68636f27da707f3ee87ba0e4f1ff100504486608)
2024-09-20 14:25:02 +02:00
cca02a3f2e chore(docs): clarify usage of related model creation
Resolves https://github.com/go-vikunja/vikunja/issues/323

(cherry picked from commit cf94cc8cab1c438eb30e63b0b02819c503b32e20)
2024-09-20 14:25:00 +02:00
95ef4e1045 fix(subscriptions): do not panic when a task does not have a subscription
(cherry picked from commit 75f3e930cd8072fc6709d1e653b177263d02c8ce)
2024-09-20 14:22:39 +02:00
8b8ec19bb3 fix(subscriptions): cleanup and simplify fetching subscribers for tasks and projects logic
Vikunja now uses one recursive CTE and a few optimizations to fetch all subscribers for a task or project. This makes the relevant code easier to maintain and more performant.

(cherry picked from commit 4ff8815fe1bfe72e02c10f6a6877c93a630f36a4)
2024-09-20 14:22:37 +02:00
4c73c74587 chore(web): move web handler package to Vikunja
(cherry picked from commit 2063da9eecf8d0980a62106a627d7f00da172138)
2024-09-20 14:22:08 +02:00
7b804efbe2 feat(event): simplify dispatching task updated event from only a task id
(cherry picked from commit 5a0d1f1dc6430f80788ae4cfacbe7da58f704841)
2024-09-20 14:21:14 +02:00
2b9b77bef2 fix(task): move task into new kanban bucket when moving between projects
Resolves https://github.com/go-vikunja/vikunja/issues/290
Resolves https://community.vikunja.io/t/tasks-moved-from-one-project-to-another-do-not-show-up-in-kanban/2689

(cherry picked from commit eed783e42f3158e6a1fdd1fffcaf6b578d0caa64)
2024-08-12 20:17:05 +02:00
12474e5be6 fix(kanban): make sure tasks which changed their done status are moved around in buckets
This fixes a bug where tasks which had their done status changed were not moved in the correct bucket. This affected both frontend and api. The move of the task between buckets is now correctly done in the api and frontend - with a bit of duplicated logic between the two. This could be optimized further in the future.

Resolves https://kolaente.dev/vikunja/vikunja/issues/2610
2024-07-18 12:39:29 +02:00
744b40e7f7 fix: missing error handling 2024-07-17 11:43:38 +02:00
58e492872a fix(kanban): put task into correct bucket when creating via kanban board 2024-07-17 09:36:33 +02:00
62412ce29b fix(kanban): do not move repeating task into a different bucket 2024-07-12 13:19:50 +02:00
7c42fb5d75 fix: lint 2024-07-12 11:49:03 +02:00
8711f7a935 fix(typesense): do not use modified opts for db fallback search 2024-07-11 12:52:09 +02:00
7f27cee6a3 fix(tasks): do not use typesense modified options to search with database 2024-07-11 12:41:40 +02:00
0b424fe95e fix(typesense): do not crash after creating a project when tasks are not yet indexed
Before this fix, creating a project with Typesense enabled would fail with an error because the tasks it fetches as part of that process do not have the task position property in their index. We now fall back to using the db for searching in that case.

In the long run, we should use typesense joins for the task position to make this more efficient.
2024-07-11 12:07:22 +02:00
359b07dabb fix(views): move bucket update to extra endpoint
BREAKING CHANGE: The bucket id of the task model is now only used internally and will not trigger a change in buckets when updating the task.

This resolves a problem where the task update routine needs to know the view context it is in. Because that's not really what it should be used for, the extra endpoint takes all required parameters and handles the complexity of actually updating the bucket.
This fixes a bug where it was impossible to move a task around between buckets of a saved filter view. In that case, the view of the bucket and the project the task was in would be different, hence the update failed.
2024-07-02 16:34:53 +02:00
2690c99438 fix(filters): explicitly use tasks.id as task id filter column
This fixes an error where filtering for labels or other related entities would fail with an error "ambiguous column name id"
2024-06-19 16:58:04 +02:00
e56b2232bb fix(typesense): do not try to sort by position when searching in a saved filter
This change fixes a bug where Typesense would try to sort by the project view of a saved filter. The view position is not indexed in Typesense, hence filtering fails. Because sorting by position is not a feature in saved filters, I've removed the logic for sorting saved filters with Typesense.
2024-06-05 10:24:28 +02:00
1843f1d0d8 fix(docs): correctly document filter query usage 2024-06-04 18:02:31 +02:00
48676050d7 feat(tasks): expand subtasks (#2345)
This change adds a parameter to expand subtasks - if provided, Vikunja will ensure all subtasks are present in the results list.

Resolves https://community.vikunja.io/t/subtasks-show-on-different-pages/2292
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2345
Co-authored-by: kolaente <k@knt.li>
Co-committed-by: kolaente <k@knt.li>
2024-06-04 10:27:23 +00:00
c47d8c6dbe fix(task): do not try to set bucket for filtered bucket configuration 2024-06-03 17:02:50 +02:00
4ce761eba7 fix(filter): trim search term before searching 2024-06-03 16:28:04 +02:00
7837bcfaae fix(task): only count unique tasks in a bucket when checking bucket limit
This fixes a bug where the current number of tasks in a bucket was computed wrong when moving tasks into a bucket with a limit. Sometimes the bug would prevent adding a task to a bucket which seemed to have space left but ultimately failed when moving the task.
2024-05-06 20:07:06 +02:00
e9de7d8a24 fix(project): delete all related entities when deleting a project 2024-04-13 21:43:44 +02:00
2f6b395334 feat(kanban): set task position to 0 (top) when it is moved into the done bucket automatically after marking it done 2024-04-06 14:35:05 +02:00
97b7592e7c fix(views): do not map bucket id from xorm 2024-03-20 10:41:58 +01:00
e7d6ee2392 fix(views): update done status of recurring tasks 2024-03-19 17:04:39 +01:00
165d291cd5 fix(views): reset bucket when moving tasks between projects 2024-03-19 14:16:05 +01:00
30b41bd143 fix(views): lint 2024-03-19 00:47:51 +01:00
803f58f402 fix(views): return correct error 2024-03-19 00:47:51 +01:00
b7b3169169 fix(views): count task buckets 2024-03-19 00:47:51 +01:00
d4bdd2d4e8 fix(views): duplicate all views and related entities when duplicating a project 2024-03-19 00:47:51 +01:00
004f1e06bb fix(views): do not return kanban tasks multiple times 2024-03-19 00:47:50 +01:00
f364f3bec8 feat(views): return position when retriving tasks 2024-03-19 00:47:48 +01:00
398c9f1056 fix(views): return tasks in their buckets 2024-03-19 00:47:48 +01:00
43f24661d7 feat(views): save view and position in Typesense 2024-03-19 00:47:47 +01:00
14353b24d7 feat(views): set default position 2024-03-19 00:47:47 +01:00
ca4e3e01c5 feat(views): recalculate all positions when updating 2024-03-19 00:47:47 +01:00
8ce476491e feat(views): only update the bucket when necessary 2024-03-19 00:47:47 +01:00
f2a0d69670 feat(views)!: make updating a bucket work again 2024-03-19 00:47:47 +01:00
a13276e28e feat(views)!: decouple bucket <-> task relationship 2024-03-19 00:47:47 +01:00
9cf84646a1 feat(views)!: move done and default bucket setting to view 2024-03-19 00:47:47 +01:00
2502776460 feat(views)!: move task position handling to its own crud entity
BREAKING CHANGE: the position of tasks now can't be updated anymore via the task update endpoint. Instead, there is a new endpoint which takes the project view into account as well.
2024-03-19 00:47:46 +01:00
a5c51d4b1e feat: emoji reactions for tasks and comments (#2196)
This PR adds reactions for tasks and comments, similar to what you can do on Gitea, GitHub, Slack and plenty of other tools.

Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2196
Co-authored-by: kolaente <k@knt.li>
Co-committed-by: kolaente <k@knt.li>
2024-03-12 19:25:58 +00:00
a66e26678e feat(filters): pass timezone down when filtering with relative date math
Resolves https://community.vikunja.io/t/my-vikunja-instance-creates-tasks-with-due-date-time-of-9am-for-tasks-with-the-word-today-word-in-it/2105/8
2024-03-11 16:28:25 +01:00
87c027aafd chore(filters): cleanup old variables 2024-03-09 19:06:35 +01:00
de320aac72 feat(filters): basic text filter works now 2024-03-09 19:06:34 +01:00