From fc4eed6eb4f3320bac6fae96f234f758996c6523 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 13 Mar 2024 17:21:20 +0100
Subject: [PATCH] fix(filters): lint

---
 .../project/partials/filter-popup.vue         |   5 +-
 .../components/project/partials/filters.vue   |   2 +-
 frontend/src/views/project/ProjectKanban.vue  |   2 +-
 frontend/src/views/project/ProjectList.vue    |  31 +-
 frontend/src/views/project/ProjectTable.vue   | 328 +++++++++---------
 5 files changed, 168 insertions(+), 200 deletions(-)

diff --git a/frontend/src/components/project/partials/filter-popup.vue b/frontend/src/components/project/partials/filter-popup.vue
index eaef47288..f1f608e2e 100644
--- a/frontend/src/components/project/partials/filter-popup.vue
+++ b/frontend/src/components/project/partials/filter-popup.vue
@@ -2,6 +2,7 @@
 	<x-button
 		variant="secondary"
 		icon="filter"
+		:class="{'has-filters': hasFilters}"
 		@click="() => modalOpen = true"
 	>
 		{{ $t('filters.title') }}
@@ -68,10 +69,6 @@ const hasFilters = computed(() => {
 })
 
 const modalOpen = ref(false)
-
-function clearFilters() {
-	value.value = {...getDefaultTaskFilterParams()}
-}
 </script>
 
 <style scoped lang="scss">
diff --git a/frontend/src/components/project/partials/filters.vue b/frontend/src/components/project/partials/filters.vue
index 8b484d506..dab0efdbe 100644
--- a/frontend/src/components/project/partials/filters.vue
+++ b/frontend/src/components/project/partials/filters.vue
@@ -27,8 +27,8 @@
 		>
 			<x-button
 				variant="secondary"
-				@click.prevent.stop="clearFiltersAndEmit"
 				class="mr-2"
+				@click.prevent.stop="clearFiltersAndEmit"
 			>
 				{{ $t('filters.clear') }}
 			</x-button>
diff --git a/frontend/src/views/project/ProjectKanban.vue b/frontend/src/views/project/ProjectKanban.vue
index 8345e4eda..e13cf6059 100644
--- a/frontend/src/views/project/ProjectKanban.vue
+++ b/frontend/src/views/project/ProjectKanban.vue
@@ -45,7 +45,7 @@
 										v-tooltip="$t('project.kanban.doneBucketHint')"
 										class="icon is-small has-text-success mr-2"
 									>
-										<icon icon="check-double"/>
+										<icon icon="check-double" />
 									</span>
 									<h2
 										class="title input"
diff --git a/frontend/src/views/project/ProjectList.vue b/frontend/src/views/project/ProjectList.vue
index 399f217bf..5588aaac3 100644
--- a/frontend/src/views/project/ProjectList.vue
+++ b/frontend/src/views/project/ProjectList.vue
@@ -73,7 +73,7 @@
 							>
 								<template v-if="canWrite">
 									<span class="icon handle">
-										<icon icon="grip-lines"/>
+										<icon icon="grip-lines" />
 									</span>
 								</template>
 							</SingleTaskInProject>
@@ -97,7 +97,6 @@ export default {name: 'List'}
 <script setup lang="ts">
 import {ref, computed, nextTick, onMounted, watch} from 'vue'
 import draggable from 'zhyswan-vuedraggable'
-import {useRoute, useRouter} from 'vue-router'
 
 import ProjectWrapper from '@/components/project/ProjectWrapper.vue'
 import ButtonLink from '@/components/misc/ButtonLink.vue'
@@ -126,7 +125,6 @@ const {
 }>()
 
 const ctaVisible = ref(false)
-const showTaskSearch = ref(false)
 
 const drag = ref(false)
 const DRAG_OPTIONS = {
@@ -140,7 +138,6 @@ const {
 	totalPages,
 	currentPage,
 	loadTasks,
-	searchTerm,
 	params,
 	sortByParam,
 } = useTaskList(() => projectId, {position: 'asc'})
@@ -198,32 +195,6 @@ onMounted(async () => {
 	ctaVisible.value = true
 })
 
-const route = useRoute()
-const router = useRouter()
-
-function searchTasks() {
-	// Only search if the search term changed
-	if (route.query as unknown as string === searchTerm.value) {
-		return
-	}
-
-	router.push({
-		name: 'project.list',
-		query: {search: searchTerm.value},
-	})
-}
-
-function hideSearchBar() {
-	// This is a workaround.
-	// When clicking on the search button, @blur from the input is fired. If we
-	// would then directly hide the whole search bar directly, no click event
-	// from the button gets fired. To prevent this, we wait 200ms until we hide
-	// everything so the button has a chance of firing the search event.
-	setTimeout(() => {
-		showTaskSearch.value = false
-	}, 200)
-}
-
 const addTaskRef = ref<typeof AddTask | null>(null)
 
 function focusNewTaskInput() {
diff --git a/frontend/src/views/project/ProjectTable.vue b/frontend/src/views/project/ProjectTable.vue
index 2fe8b809f..9ea642976 100644
--- a/frontend/src/views/project/ProjectTable.vue
+++ b/frontend/src/views/project/ProjectTable.vue
@@ -67,7 +67,7 @@
 							</card>
 						</template>
 					</Popup>
-					<FilterPopup v-model="params"/>
+					<FilterPopup v-model="params" />
 				</div>
 			</div>
 		</template>
@@ -84,175 +84,175 @@
 					<div class="has-horizontal-overflow">
 						<table class="table has-actions is-hoverable is-fullwidth mb-0">
 							<thead>
-							<tr>
-								<th v-if="activeColumns.index">
-									#
-									<Sort
-										:order="sortBy.index"
-										@click="sort('index')"
-									/>
-								</th>
-								<th v-if="activeColumns.done">
-									{{ $t('task.attributes.done') }}
-									<Sort
-										:order="sortBy.done"
-										@click="sort('done')"
-									/>
-								</th>
-								<th v-if="activeColumns.title">
-									{{ $t('task.attributes.title') }}
-									<Sort
-										:order="sortBy.title"
-										@click="sort('title')"
-									/>
-								</th>
-								<th v-if="activeColumns.priority">
-									{{ $t('task.attributes.priority') }}
-									<Sort
-										:order="sortBy.priority"
-										@click="sort('priority')"
-									/>
-								</th>
-								<th v-if="activeColumns.labels">
-									{{ $t('task.attributes.labels') }}
-								</th>
-								<th v-if="activeColumns.assignees">
-									{{ $t('task.attributes.assignees') }}
-								</th>
-								<th v-if="activeColumns.dueDate">
-									{{ $t('task.attributes.dueDate') }}
-									<Sort
-										:order="sortBy.due_date"
-										@click="sort('due_date')"
-									/>
-								</th>
-								<th v-if="activeColumns.startDate">
-									{{ $t('task.attributes.startDate') }}
-									<Sort
-										:order="sortBy.start_date"
-										@click="sort('start_date')"
-									/>
-								</th>
-								<th v-if="activeColumns.endDate">
-									{{ $t('task.attributes.endDate') }}
-									<Sort
-										:order="sortBy.end_date"
-										@click="sort('end_date')"
-									/>
-								</th>
-								<th v-if="activeColumns.percentDone">
-									{{ $t('task.attributes.percentDone') }}
-									<Sort
-										:order="sortBy.percent_done"
-										@click="sort('percent_done')"
-									/>
-								</th>
-								<th v-if="activeColumns.doneAt">
-									{{ $t('task.attributes.doneAt') }}
-									<Sort
-										:order="sortBy.done_at"
-										@click="sort('done_at')"
-									/>
-								</th>
-								<th v-if="activeColumns.created">
-									{{ $t('task.attributes.created') }}
-									<Sort
-										:order="sortBy.created"
-										@click="sort('created')"
-									/>
-								</th>
-								<th v-if="activeColumns.updated">
-									{{ $t('task.attributes.updated') }}
-									<Sort
-										:order="sortBy.updated"
-										@click="sort('updated')"
-									/>
-								</th>
-								<th v-if="activeColumns.createdBy">
-									{{ $t('task.attributes.createdBy') }}
-								</th>
-							</tr>
+								<tr>
+									<th v-if="activeColumns.index">
+										#
+										<Sort
+											:order="sortBy.index"
+											@click="sort('index')"
+										/>
+									</th>
+									<th v-if="activeColumns.done">
+										{{ $t('task.attributes.done') }}
+										<Sort
+											:order="sortBy.done"
+											@click="sort('done')"
+										/>
+									</th>
+									<th v-if="activeColumns.title">
+										{{ $t('task.attributes.title') }}
+										<Sort
+											:order="sortBy.title"
+											@click="sort('title')"
+										/>
+									</th>
+									<th v-if="activeColumns.priority">
+										{{ $t('task.attributes.priority') }}
+										<Sort
+											:order="sortBy.priority"
+											@click="sort('priority')"
+										/>
+									</th>
+									<th v-if="activeColumns.labels">
+										{{ $t('task.attributes.labels') }}
+									</th>
+									<th v-if="activeColumns.assignees">
+										{{ $t('task.attributes.assignees') }}
+									</th>
+									<th v-if="activeColumns.dueDate">
+										{{ $t('task.attributes.dueDate') }}
+										<Sort
+											:order="sortBy.due_date"
+											@click="sort('due_date')"
+										/>
+									</th>
+									<th v-if="activeColumns.startDate">
+										{{ $t('task.attributes.startDate') }}
+										<Sort
+											:order="sortBy.start_date"
+											@click="sort('start_date')"
+										/>
+									</th>
+									<th v-if="activeColumns.endDate">
+										{{ $t('task.attributes.endDate') }}
+										<Sort
+											:order="sortBy.end_date"
+											@click="sort('end_date')"
+										/>
+									</th>
+									<th v-if="activeColumns.percentDone">
+										{{ $t('task.attributes.percentDone') }}
+										<Sort
+											:order="sortBy.percent_done"
+											@click="sort('percent_done')"
+										/>
+									</th>
+									<th v-if="activeColumns.doneAt">
+										{{ $t('task.attributes.doneAt') }}
+										<Sort
+											:order="sortBy.done_at"
+											@click="sort('done_at')"
+										/>
+									</th>
+									<th v-if="activeColumns.created">
+										{{ $t('task.attributes.created') }}
+										<Sort
+											:order="sortBy.created"
+											@click="sort('created')"
+										/>
+									</th>
+									<th v-if="activeColumns.updated">
+										{{ $t('task.attributes.updated') }}
+										<Sort
+											:order="sortBy.updated"
+											@click="sort('updated')"
+										/>
+									</th>
+									<th v-if="activeColumns.createdBy">
+										{{ $t('task.attributes.createdBy') }}
+									</th>
+								</tr>
 							</thead>
 							<tbody>
-							<tr
-								v-for="t in tasks"
-								:key="t.id"
-							>
-								<td v-if="activeColumns.index">
-									<router-link :to="taskDetailRoutes[t.id]">
-										<template v-if="t.identifier === ''">
-											#{{ t.index }}
-										</template>
-										<template v-else>
-											{{ t.identifier }}
-										</template>
-									</router-link>
-								</td>
-								<td v-if="activeColumns.done">
-									<Done
-										:is-done="t.done"
-										variant="small"
+								<tr
+									v-for="t in tasks"
+									:key="t.id"
+								>
+									<td v-if="activeColumns.index">
+										<router-link :to="taskDetailRoutes[t.id]">
+											<template v-if="t.identifier === ''">
+												#{{ t.index }}
+											</template>
+											<template v-else>
+												{{ t.identifier }}
+											</template>
+										</router-link>
+									</td>
+									<td v-if="activeColumns.done">
+										<Done
+											:is-done="t.done"
+											variant="small"
+										/>
+									</td>
+									<td v-if="activeColumns.title">
+										<router-link :to="taskDetailRoutes[t.id]">
+											{{ t.title }}
+										</router-link>
+									</td>
+									<td v-if="activeColumns.priority">
+										<PriorityLabel
+											:priority="t.priority"
+											:done="t.done"
+											:show-all="true"
+										/>
+									</td>
+									<td v-if="activeColumns.labels">
+										<Labels :labels="t.labels" />
+									</td>
+									<td v-if="activeColumns.assignees">
+										<AssigneeList
+											v-if="t.assignees.length > 0"
+											:assignees="t.assignees"
+											:avatar-size="28"
+											class="ml-1"
+											:inline="true"
+										/>
+									</td>
+									<DateTableCell
+										v-if="activeColumns.dueDate"
+										:date="t.dueDate"
 									/>
-								</td>
-								<td v-if="activeColumns.title">
-									<router-link :to="taskDetailRoutes[t.id]">
-										{{ t.title }}
-									</router-link>
-								</td>
-								<td v-if="activeColumns.priority">
-									<PriorityLabel
-										:priority="t.priority"
-										:done="t.done"
-										:show-all="true"
+									<DateTableCell
+										v-if="activeColumns.startDate"
+										:date="t.startDate"
 									/>
-								</td>
-								<td v-if="activeColumns.labels">
-									<Labels :labels="t.labels"/>
-								</td>
-								<td v-if="activeColumns.assignees">
-									<AssigneeList
-										v-if="t.assignees.length > 0"
-										:assignees="t.assignees"
-										:avatar-size="28"
-										class="ml-1"
-										:inline="true"
+									<DateTableCell
+										v-if="activeColumns.endDate"
+										:date="t.endDate"
 									/>
-								</td>
-								<DateTableCell
-									v-if="activeColumns.dueDate"
-									:date="t.dueDate"
-								/>
-								<DateTableCell
-									v-if="activeColumns.startDate"
-									:date="t.startDate"
-								/>
-								<DateTableCell
-									v-if="activeColumns.endDate"
-									:date="t.endDate"
-								/>
-								<td v-if="activeColumns.percentDone">
-									{{ t.percentDone * 100 }}%
-								</td>
-								<DateTableCell
-									v-if="activeColumns.doneAt"
-									:date="t.doneAt"
-								/>
-								<DateTableCell
-									v-if="activeColumns.created"
-									:date="t.created"
-								/>
-								<DateTableCell
-									v-if="activeColumns.updated"
-									:date="t.updated"
-								/>
-								<td v-if="activeColumns.createdBy">
-									<User
-										:avatar-size="27"
-										:show-username="false"
-										:user="t.createdBy"
+									<td v-if="activeColumns.percentDone">
+										{{ t.percentDone * 100 }}%
+									</td>
+									<DateTableCell
+										v-if="activeColumns.doneAt"
+										:date="t.doneAt"
 									/>
-								</td>
-							</tr>
+									<DateTableCell
+										v-if="activeColumns.created"
+										:date="t.created"
+									/>
+									<DateTableCell
+										v-if="activeColumns.updated"
+										:date="t.updated"
+									/>
+									<td v-if="activeColumns.createdBy">
+										<User
+											:avatar-size="27"
+											:show-username="false"
+											:user="t.createdBy"
+										/>
+									</td>
+								</tr>
 							</tbody>
 						</table>
 					</div>