From fa628edc0cb4f415093d1852808163a10822e726 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Tue, 7 May 2024 16:53:21 +0200
Subject: [PATCH] fix(project): make sure gantt and kanban views shared with
 link share are full width

Resolves https://github.com/go-vikunja/vikunja/issues/258
---
 .../src/components/home/contentLinkShare.vue  | 83 +++++++++++++------
 frontend/src/modelTypes/IProjectView.ts       |  9 +-
 frontend/src/styles/theme/link-share.scss     | 29 -------
 3 files changed, 64 insertions(+), 57 deletions(-)

diff --git a/frontend/src/components/home/contentLinkShare.vue b/frontend/src/components/home/contentLinkShare.vue
index cc14d318f..e5ed6eb15 100644
--- a/frontend/src/components/home/contentLinkShare.vue
+++ b/frontend/src/components/home/contentLinkShare.vue
@@ -1,26 +1,27 @@
 <template>
 	<div
-		:class="[background ? 'has-background' : '', $route.name as string +'-view']"
+		:class="{
+			'has-background': background,
+			'link-share-is-fullwidth': isFullWidth,
+		}"
 		:style="{'background-image': `url(${background})`}"
 		class="link-share-container"
 	>
-		<div class="container has-text-centered link-share-view">
-			<div class="column is-10 is-offset-1">
-				<Logo
-					v-if="logoVisible"
-					class="logo"
-				/>
-				<h1
-					:class="{'m-0': !logoVisible}"
-					:style="{ 'opacity': currentProject?.title === '' ? '0': '1' }"
-					class="title"
-				>
-					{{ currentProject?.title === '' ? $t('misc.loading') : currentProject?.title }}
-				</h1>
-				<div class="box has-text-left view">
-					<router-view />
-					<PoweredByLink />
-				</div>
+		<div class="has-text-centered link-share-view">
+			<Logo
+				v-if="logoVisible"
+				class="logo"
+			/>
+			<h1
+				:class="{'m-0': !logoVisible}"
+				:style="{ 'opacity': currentProject?.title === '' ? '0': '1' }"
+				class="title"
+			>
+				{{ currentProject?.title === '' ? $t('misc.loading') : currentProject?.title }}
+			</h1>
+			<div class="box has-text-left view">
+				<router-view />
+				<PoweredByLink />
 			</div>
 		</div>
 	</div>
@@ -30,11 +31,13 @@
 import {computed} from 'vue'
 
 import {useBaseStore} from '@/stores/base'
+import {useRoute} from 'vue-router'
 
 import Logo from '@/components/home/Logo.vue'
 import PoweredByLink from './PoweredByLink.vue'
 import {useProjectStore} from '@/stores/projects'
 import {useLabelStore} from '@/stores/labels'
+import {PROJECT_VIEW_KINDS} from '@/modelTypes/IProjectView'
 
 const baseStore = useBaseStore()
 const currentProject = computed(() => baseStore.currentProject)
@@ -46,6 +49,20 @@ projectStore.loadAllProjects()
 
 const labelStore = useLabelStore()
 labelStore.loadAllLabels()
+
+const route = useRoute()
+const isFullWidth = computed(() => {
+	const viewId = route.params?.viewId ?? null
+	const projectId = route.params?.projectId ?? null
+	if (!viewId || !projectId) {
+		return false
+	}
+
+	const view = projectStore.projects[Number(projectId)]?.views.find(v => v.id === Number(viewId))
+
+	return view?.viewKind === PROJECT_VIEW_KINDS.KANBAN ||
+		view?.viewKind === PROJECT_VIEW_KINDS.GANTT
+})
 </script>
 
 <style lang="scss" scoped>
@@ -57,20 +74,34 @@ labelStore.loadAllLabels()
 .logo {
 	max-width: 300px;
 	width: 90%;
-	margin: 2rem 0 1.5rem;
+	margin: 1rem auto 2rem;
 	height: 100px;
 }
 
-.column {
-	max-width: 100%;
-}
-
 .title {
 	text-shadow: 0 0 1rem var(--white);
 }
 
-// FIXME: this should be defined somewhere deep
-.link-share-view .card {
-	background-color: var(--white);
+.link-share-view {
+	width: 100%;
+	max-width: $desktop;
+	margin: 0 auto;
+}
+
+.link-share-container.link-share-is-fullwidth {
+	.link-share-view {
+		max-width: 100vw;
+	}
+}
+
+.link-share-container:not(.has-background) {
+	:deep(.loader-container, .gantt-chart-container > .card) {
+		box-shadow: none !important;
+		border: none;
+
+		.task-add {
+			padding: 1rem 0 0;
+		}
+	}
 }
 </style>
diff --git a/frontend/src/modelTypes/IProjectView.ts b/frontend/src/modelTypes/IProjectView.ts
index 6a003b8ff..076f072af 100644
--- a/frontend/src/modelTypes/IProjectView.ts
+++ b/frontend/src/modelTypes/IProjectView.ts
@@ -1,8 +1,13 @@
 import type {IAbstract} from './IAbstract'
 import type {IProject} from '@/modelTypes/IProject'
 
-export const PROJECT_VIEW_KINDS = ['list', 'gantt', 'table', 'kanban']
-export type ProjectViewKind = typeof PROJECT_VIEW_KINDS[number]
+export const PROJECT_VIEW_KINDS = {
+	LIST: 'list',
+	GANTT: 'gantt',
+	TABLE: 'table',
+	KANBAN: 'kanban',
+} as const
+export type ProjectViewKind = typeof PROJECT_VIEW_KINDS[keyof typeof PROJECT_VIEW_KINDS]
 
 export const PROJECT_VIEW_BUCKET_CONFIGURATION_MODES = ['none', 'manual', 'filter']
 export type ProjectViewBucketConfigurationMode = typeof PROJECT_VIEW_BUCKET_CONFIGURATION_MODES[number]
diff --git a/frontend/src/styles/theme/link-share.scss b/frontend/src/styles/theme/link-share.scss
index dffcde4c1..ee46bdddb 100644
--- a/frontend/src/styles/theme/link-share.scss
+++ b/frontend/src/styles/theme/link-share.scss
@@ -14,33 +14,4 @@
 			border-radius: $radius !important;
 		}
   }
-}
-
-.link-share-container {
-	&.project\.gantt-view,
-  &.project\.kanban-view {
-    .container {
-      max-width: 100vw;
-
-      .column {
-        width: 100%;
-        margin: 0;
-      }
-    }
-  }
-}
-
-.link-share-container:not(.has-background) {
-  .list-view {
-    max-width: 100%;
-  }
-
-  .loader-container, .gantt-chart-container > .card {
-		box-shadow: none !important;
-		border: none;
-
-		.task-add {
-			padding: 1rem 0 0;
-		}
-  }
 }
\ No newline at end of file