ami/tl-vikunja
1
0
Fork 0
Code

fix(kanban): update task done status after moving it into done bucket

Browse Source 
Resolves https://kolaente.dev/vikunja/vikunja/issues/2518
This commit is contained in:
kolaente 2024-07-11 13:17:33 +02:00
parent 8711f7a935
commit ec0c05fd47
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/components/project/views/ProjectKanban.vue
View File

@ -490,12 +490,6 @@ async function updateTaskPosition(e) {
taskBefore !== null ? taskBefore.position : null, taskBefore !== null ? taskBefore.position : null,
taskAfter !== null ? taskAfter.position : null, taskAfter !== null ? taskAfter.position : null,
) )
if (
oldBucket !== undefined && // This shouldn't actually be `undefined`, but let's play it safe.
newBucket.id !== oldBucket.id
) {
newTask.done = project.value?.doneBucketId === newBucket.id
}
let bucketHasChanged = false let bucketHasChanged = false
if ( if (
@ -522,12 +516,14 @@ async function updateTaskPosition(e) {
await taskPositionService.value.update(newPosition) await taskPositionService.value.update(newPosition)
if(bucketHasChanged) { if(bucketHasChanged) {
await taskBucketService.value.update(new TaskBucketModel({ const updatedTaskBucket = await taskBucketService.value.update(new TaskBucketModel({
taskId: newTask.id, taskId: newTask.id,
bucketId: newTask.bucketId, bucketId: newTask.bucketId,
projectViewId: viewId, projectViewId: viewId,
projectId: project.value.id, projectId: project.value.id,
})) }))
newTask.done = updatedTaskBucket.taskDone
kanbanStore.setTaskInBucket(newTask)
} }
// Make sure the first and second task don't both get position 0 assigned // Make sure the first and second task don't both get position 0 assigned