ami/tl-vikunja
1
0
Fork 0
Code

fix(semver): fix produced version number (#2378)

Browse Source 
The "+" is not compatible and leads to problems with semver version parsers.
Unsure if breaking?

Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2378
Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Co-committed-by: Dominik Pschenitschni <mail@celement.de>
This commit is contained in:
Dominik Pschenitschni 2024-06-13 14:22:12 +00:00 committed by konrad
parent 7093f71372
commit eb0f1a977b
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/content/doc/setup/versions.md
View File

@ -16,7 +16,7 @@ Vikunja api is available in two different release flavors.
## Stable ## Stable
Stable releases have a fixed version number like `0.18.2` and are published at irregular intervals whenever a new version is ready. Stable releases have a fixed version number like `0.20.2` and are published at irregular intervals whenever a new version is ready.
They receive few bugfixes and security patches. They receive few bugfixes and security patches.
We use [Semantic Versioning](https://semver.org) for these releases. We use [Semantic Versioning](https://semver.org) for these releases.
@ -28,7 +28,7 @@ As such, they contain the current development code and are more likely to have b
There might be multiple new such builds a day. There might be multiple new such builds a day.
Versions contain the last stable version, the number of commits since then and the commit the currently running binary was built from. Versions contain the last stable version, the number of commits since then and the commit the currently running binary was built from.
They look like this: `v0.18.1+269-5cc4927b9e` They look like this: `v0.20.2-75-6049427322`
Since a release is also cut from the main branch at some point, features from unstable will eventually become available in stable releases. Since a release is also cut from the main branch at some point, features from unstable will eventually become available in stable releases.
At the point in time of a new version release, the unstable build is the same exact thing. At the point in time of a new version release, the unstable build is the same exact thing.

1
magefile.go
View File

@ -97,7 +97,6 @@ func setVersion() {
os.Exit(1) os.Exit(1)
} }
VersionNumber = strings.Trim(string(version), "\n") VersionNumber = strings.Trim(string(version), "\n")
VersionNumber = strings.Replace(VersionNumber, "-", "+", 1)
VersionNumber = strings.Replace(VersionNumber, "-g", "-", 1) VersionNumber = strings.Replace(VersionNumber, "-g", "-", 1)
if os.Getenv("DRONE_TAG") != "" { if os.Getenv("DRONE_TAG") != "" {