ami/tl-vikunja
1
0
Fork 0
Code Activity

Added new checks (#2)

Browse Source 
* added gocyclo-check
* Added new tests to drone
* Added new checks to makefile
This commit is contained in:
konrad
2018-09-23 19:15:14 +00:00
committed by Gitea
parent b912ff4176
commit e724aeb206
9 changed files with 34 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
routes/api/v1/list_by_namespace.go
View File

@ -39,7 +39,7 @@ func GetListsByNamespaceID(c echo.Context) error {
if models.IsErrUserDoesNotHaveAccessToNamespace(err) {
return c.JSON(http.StatusForbidden, models.Message{"You don't have access to this namespace."})
}
return c.JSON(http.StatusInternalServerError, models.Message{"An error occured."})
return c.JSON(http.StatusInternalServerError, models.Message{"An error occurred."})
}
// Get the lists
@ -48,7 +48,7 @@ func GetListsByNamespaceID(c echo.Context) error {
if models.IsErrNamespaceDoesNotExist(err) {
return c.JSON(http.StatusNotFound, models.Message{"Namespace not found."})
}
return c.JSON(http.StatusInternalServerError, models.Message{"An error occured."})
return c.JSON(http.StatusInternalServerError, models.Message{"An error occurred."})
}
return c.JSON(http.StatusOK, lists)
}

2
routes/api/v1/user_list.go
View File

@ -32,7 +32,7 @@ func UserList(c echo.Context) error {
users, err := models.ListUsers(s)
if err != nil {
models.Log.Error(err.Error())
return echo.NewHTTPError(http.StatusInternalServerError, "An error occured.")
return echo.NewHTTPError(http.StatusInternalServerError, "An error occurred.")
}
// Obfuscate the mailadresses

3
routes/api/v1/user_update_password.go
View File

@ -30,6 +30,9 @@ func UserChangePassword(c echo.Context) error {
// Check if the user is itself
userJWTinfo, err := models.GetCurrentUser(c)
if err != nil {
return c.JSON(http.StatusInternalServerError, models.Message{"Error getting current user."})
}
if userJWTinfo.ID != userID {
return echo.ErrUnauthorized

2
routes/crud/read_all.go
View File

@ -30,7 +30,7 @@ func (c *WebHandler) ReadAllWeb(ctx echo.Context) error {
return echo.NewHTTPError(http.StatusNotFound, "This namespace does not exist.")
}
return echo.NewHTTPError(http.StatusInternalServerError, "An error occured.")
return echo.NewHTTPError(http.StatusInternalServerError, "An error occurred.")
}
return ctx.JSON(http.StatusOK, lists)

2
routes/crud/read_one.go
View File

@ -31,7 +31,7 @@ func (c *WebHandler) ReadOneWeb(ctx echo.Context) error {
return echo.NewHTTPError(http.StatusNotFound)
}
return echo.NewHTTPError(http.StatusInternalServerError, "An error occured.")
return echo.NewHTTPError(http.StatusInternalServerError, "An error occurred.")
}
// Check rights