implemented team create method

models/crudable.go

@@ -7,4 +7,8 @@ type CRUDable interface {
 	ReadAll(*User) (interface{}, error)
 	Update(int64) error
 	Delete(int64) error
+
+	// This method is needed, because old values would otherwise remain in the struct.
+	// TODO find a way of not needing an extra function
+	Empty()
 }

models/error.go

@@ -353,3 +353,22 @@ func IsErrNeedToBeNamespaceAdmin(err error) bool {
 func (err ErrNeedToBeNamespaceAdmin) Error() string {
 	return fmt.Sprintf("You need to be namespace owner to do that [NamespaceID: %d, UserID: %d]", err.NamespaceID, err.UserID)
 }
+
+// ============
+// Team errors
+// ============
+
+// ErrTeamNameCannotBeEmpty represents an error, where a namespace owner is empty.
+type ErrTeamNameCannotBeEmpty struct {
+	TeamID int64
+}
+
+// IsErrTeamNameCannotBeEmpty checks if an error is a ErrNamespaceDoesNotExist.
+func IsErrTeamNameCannotBeEmpty(err error) bool {
+	_, ok := err.(ErrTeamNameCannotBeEmpty)
+	return ok
+}
+
+func (err ErrTeamNameCannotBeEmpty) Error() string {
+	return fmt.Sprintf("Team name cannot be empty [Team ID: %d]", err.TeamID)
+}

models/teams.go

@@ -2,16 +2,19 @@ package models
 
 // Team holds a team object
 type Team struct {
-	ID          int64   `xorm:"int(11) autoincr not null unique pk" json:"id"`
-	Name        string  `xorm:"varchar(250) not null" json:"name"`
-	Description string  `xorm:"varchar(250)" json:"description"`
-	Rights      []int64 `xorm:"varchar(250)" json:"rights"`
-	CreatedByID int64   `xorm:"int(11) not null" json:"-"`
+	ID          int64  `xorm:"int(11) autoincr not null unique pk" json:"id"`
+	Name        string `xorm:"varchar(250) not null" json:"name"`
+	Description string `xorm:"varchar(250)" json:"description"`
+	CreatedByID int64  `xorm:"int(11) not null" json:"-"`
+
+	CreatedBy *User   `xorm:"-" json:"created_by"`
+	Members   []*User `xorm:"-" json:"members"`
 
 	Created int64 `xorm:"created" json:"created"`
 	Updated int64 `xorm:"updated" json:"updated"`
 
-	CreatedBy User `json:"created_by"`
+	CRUDable `xorm:"-" json:"-"`
+	Rights   `xorm:"-" json:"-"`
 }
 
 // TableName makes beautiful table names
@@ -19,14 +22,19 @@ func (Team) TableName() string {
 	return "teams"
 }
 
+func (t *Team) AfterLoad() {
+	// Get the owner
+	*t.CreatedBy, _, _ = GetUserByID(t.CreatedByID)
+}
+
 // TeamMember defines the relationship between a user and a team
 type TeamMember struct {
-	ID     int64 `xorm:"int(11) autoincr not null unique pk"`
-	TeamID int64 `xorm:"int(11) autoincr not null"`
-	UserID int64 `xorm:"int(11) autoincr not null"`
+	ID     int64 `xorm:"int(11) autoincr not null unique pk" json:"id"`
+	TeamID int64 `xorm:"int(11) not null" json:"team_id"`
+	UserID int64 `xorm:"int(11) not null" json:"user_id"`
 
-	Created int64 `xorm:"created"`
-	Updated int64 `xorm:"updated"`
+	Created int64 `xorm:"created" json:"created"`
+	Updated int64 `xorm:"updated" json:"updated"`
 }
 
 // TableName makes beautiful table names
@@ -36,12 +44,13 @@ func (TeamMember) TableName() string {
 
 // TeamNamespace defines the relationship between a Team and a Namespace
 type TeamNamespace struct {
-	ID          int64 `xorm:"int(11) autoincr not null unique pk"`
-	TeamID      int64 `xorm:"int(11) autoincr not null"`
-	NamespaceID int64 `xorm:"int(11) autoincr not null"`
+	ID          int64   `xorm:"int(11) autoincr not null unique pk" json:"id"`
+	TeamID      int64   `xorm:"int(11) not null" json:"team_id"`
+	NamespaceID int64   `xorm:"int(11) not null" json:"namespace_id"`
+	Rights      []int64 `xorm:"varchar(250)" json:"rights"`
 
-	Created int64 `xorm:"created"`
-	Updated int64 `xorm:"updated"`
+	Created int64 `xorm:"created" json:"created"`
+	Updated int64 `xorm:"updated" json:"updated"`
 }
 
 // TableName makes beautiful table names
@@ -51,12 +60,13 @@ func (TeamNamespace) TableName() string {
 
 // TeamList defines the relation between a team and a list
 type TeamList struct {
-	ID     int64 `xorm:"int(11) autoincr not null unique pk"`
-	TeamID int64 `xorm:"int(11) autoincr not null"`
-	ListID int64 `xorm:"int(11) autoincr not null"`
+	ID     int64   `xorm:"int(11) autoincr not null unique pk" json:"id"`
+	TeamID int64   `xorm:"int(11) not null" json:"team_id"`
+	ListID int64   `xorm:"int(11) not null" json:"list_id"`
+	Rights []int64 `xorm:"varchar(250)" json:"rights"`
 
-	Created int64 `xorm:"created"`
-	Updated int64 `xorm:"updated"`
+	Created int64 `xorm:"created" json:"created"`
+	Updated int64 `xorm:"updated" json:"updated"`
 }
 
 // TableName makes beautiful table names
@@ -73,3 +83,15 @@ func GetAllTeamsByNamespaceID(id int64) (teams []*Team, err error) {
 
 	return
 }
+
+// Empty empties a struct. Because we heavily use pointers, the old values remain in the struct.
+// If you then update by not providing evrything, you have i.e. the old description still in the
+// newly created team,  but you didn't provided one.
+func (t *Team) Empty() {
+	t.ID = 0
+	t.CreatedByID = 0
+	t.CreatedBy = &User{}
+	t.Name = ""
+	t.Description = ""
+	t.Members = []*User{}
+}

models/teams_create.go

@@ -0,0 +1,19 @@
+package models
+
+func (t *Team) Create(doer *User, _ int64) (err error) {
+	// Check if we have a name
+	if t.Name == "" {
+		return ErrTeamNameCannotBeEmpty{}
+	}
+
+	// Set the id to 0, otherwise the creation fails because of double keys
+	t.CreatedByID = doer.ID
+	t.CreatedBy = doer
+
+	_, err = x.Insert(t)
+	if err != nil {
+		return
+	}
+
+	return
+}

models/teams_rights.go

@@ -0,0 +1,7 @@
+package models
+
+// CanCreate checks if the user can create a new team
+func (n *Team) CanCreate(user *User, id int64) bool {
+	// This is currently a dummy function, later on we could imagine global limits etc.
+	return true
+}