1
0

feat: don't open task detail in modal for list and table view

This commit is contained in:
Dominik Pschenitschni
2022-01-19 23:58:54 +01:00
parent 3d420c3770
commit de626eab31
5 changed files with 32 additions and 30 deletions

View File

@ -181,7 +181,6 @@
<script setup lang="ts">
import { toRef, computed, Ref } from 'vue'
import { useRouter } from 'vue-router'
import { useStorage } from '@vueuse/core'
@ -273,14 +272,15 @@ function sort(property : keyof SortBy) {
}
}
const router = useRouter()
// TODO: re-enable opening task detail in modal
// const router = useRouter()
const taskDetailRoutes = computed(() => Object.fromEntries(
tasks.value.map(({id}) => ([
id,
{
name: 'task.detail',
params: { id },
state: { backdropView: router.currentRoute.value.fullPath },
// state: { backdropView: router.currentRoute.value.fullPath },
},
])),
))

View File

@ -4,10 +4,10 @@
variant="scrolling"
class="task-detail-view-modal"
>
<a @click="close()" class="close">
<BaseButton @click="close()" class="close">
<icon icon="times"/>
</a>
<task-detail-view :task-id="props.taskId"/>
</BaseButton>
<slot />
</modal>
</template>
@ -15,14 +15,7 @@
import {computed} from 'vue'
import {useRouter, useRoute} from 'vue-router'
import TaskDetailView from './TaskDetailView.vue'
const props = defineProps({
taskId: {
type: Number,
required: true,
},
})
import BaseButton from '@/components/base/BaseButton.vue'
const route = useRoute()
const historyState = computed(() => route.fullPath && window.history.state)