fix: directly set arrays, objects and delete directly
Not needed since vue3 uses proxies
This commit is contained in:
@ -1,5 +1,3 @@
|
||||
import Vue from 'vue'
|
||||
|
||||
import {findIndexById} from '@/helpers/find'
|
||||
|
||||
export default {
|
||||
@ -10,7 +8,7 @@ export default {
|
||||
mutations: {
|
||||
set(state, attachments) {
|
||||
console.debug('Set attachments', attachments)
|
||||
Vue.set(state, 'attachments', attachments)
|
||||
state.attachments = attachments
|
||||
},
|
||||
add(state, attachment) {
|
||||
console.debug('Add attachement', attachment)
|
||||
|
@ -1,5 +1,3 @@
|
||||
import Vue from 'vue'
|
||||
|
||||
import {CONFIG} from '../mutation-types'
|
||||
import {HTTPFactory} from '@/http-common'
|
||||
import {objectToCamelCase} from '@/helpers/case'
|
||||
@ -58,7 +56,7 @@ export default {
|
||||
state.auth.local.enabled = auth.local.enabled
|
||||
state.auth.openidConnect.enabled = auth.openidConnect.enabled
|
||||
state.auth.openidConnect.redirectUrl = auth.openidConnect.redirectUrl
|
||||
Vue.set(state.auth.openidConnect, 'providers', auth.openidConnect.providers)
|
||||
state.auth.openidConnect.providers = auth.openidConnect.providers
|
||||
},
|
||||
},
|
||||
actions: {
|
||||
|
@ -1,4 +1,3 @@
|
||||
import Vue from 'vue'
|
||||
import cloneDeep from 'lodash/cloneDeep'
|
||||
|
||||
import BucketService from '../../services/bucket'
|
||||
@ -34,8 +33,8 @@ export default {
|
||||
setBuckets(state, buckets) {
|
||||
state.buckets = buckets
|
||||
buckets.forEach(b => {
|
||||
Vue.set(state.taskPagesPerBucket, b.id, 1)
|
||||
Vue.set(state.allTasksLoadedForBucket, b.id, false)
|
||||
state.taskPagesPerBucket[b.id] = 1
|
||||
state.allTasksLoadedForBucket[b.id] = false
|
||||
})
|
||||
},
|
||||
addBucket(state, bucket) {
|
||||
@ -51,18 +50,18 @@ export default {
|
||||
setBucketById(state, bucket) {
|
||||
for (const b in state.buckets) {
|
||||
if (state.buckets[b].id === bucket.id) {
|
||||
Vue.set(state.buckets, b, bucket)
|
||||
state.buckets[b] = bucket
|
||||
return
|
||||
}
|
||||
}
|
||||
},
|
||||
setBucketByIndex(state, {bucketIndex, bucket}) {
|
||||
Vue.set(state.buckets, bucketIndex, bucket)
|
||||
state.buckets[bucketIndex] = bucket
|
||||
},
|
||||
setTaskInBucketByIndex(state, {bucketIndex, taskIndex, task}) {
|
||||
const bucket = state.buckets[bucketIndex]
|
||||
bucket.tasks[taskIndex] = task
|
||||
Vue.set(state.buckets, bucketIndex, bucket)
|
||||
state.buckets[bucketIndex] = bucket
|
||||
},
|
||||
setTaskInBucket(state, task) {
|
||||
// If this gets invoked without any tasks actually loaded, we can save the hassle of finding the task
|
||||
@ -83,7 +82,8 @@ export default {
|
||||
addTaskToBucketAndSort(state, task)
|
||||
}
|
||||
|
||||
Vue.set(state.buckets, b, bucket)
|
||||
state.buckets[b] = bucket
|
||||
|
||||
found = true
|
||||
return
|
||||
}
|
||||
@ -129,7 +129,7 @@ export default {
|
||||
if (state.buckets[b].tasks[t].id === task.id) {
|
||||
const bucket = state.buckets[b]
|
||||
bucket.tasks.splice(t, 1)
|
||||
Vue.set(state.buckets, b, bucket)
|
||||
state.buckets[b] = bucket
|
||||
return
|
||||
}
|
||||
}
|
||||
@ -138,13 +138,14 @@ export default {
|
||||
}
|
||||
},
|
||||
setBucketLoading(state, {bucketId, loading}) {
|
||||
Vue.set(state.bucketLoading, bucketId, loading)
|
||||
state.bucketLoading[bucketId] = loading
|
||||
},
|
||||
setTasksLoadedForBucketPage(state, {bucketId, page}) {
|
||||
Vue.set(state.taskPagesPerBucket, bucketId, page)
|
||||
state.taskPagesPerBucket[bucketId] = page
|
||||
|
||||
},
|
||||
setAllTasksLoadedForBucket(state, bucketId) {
|
||||
Vue.set(state.allTasksLoadedForBucket, bucketId, true)
|
||||
state.allTasksLoadedForBucket[bucketId] = true
|
||||
},
|
||||
},
|
||||
getters: {
|
||||
|
@ -1,5 +1,4 @@
|
||||
import LabelService from '@/services/label'
|
||||
import Vue from 'vue'
|
||||
import {setLoading} from '@/store/helper'
|
||||
|
||||
export default {
|
||||
@ -12,14 +11,14 @@ export default {
|
||||
mutations: {
|
||||
setLabels(state, labels) {
|
||||
labels.forEach(l => {
|
||||
Vue.set(state.labels, l.id, l)
|
||||
state.labels[l.id] = l
|
||||
})
|
||||
},
|
||||
setLabel(state, label) {
|
||||
Vue.set(state.labels, label.id, label)
|
||||
state.labels[label.id] = label
|
||||
},
|
||||
removeLabelById(state, label) {
|
||||
Vue.delete(state.labels, label.id)
|
||||
delete state.labels[label.id]
|
||||
},
|
||||
setLoaded(state, loaded) {
|
||||
state.loaded = loaded
|
||||
|
@ -1,4 +1,3 @@
|
||||
import Vue from 'vue'
|
||||
import ListService from '@/services/list'
|
||||
import {setLoading} from '@/store/helper'
|
||||
import {removeListFromHistory} from '@/modules/listHistory.ts'
|
||||
@ -11,11 +10,11 @@ export default {
|
||||
state: () => ({}),
|
||||
mutations: {
|
||||
setList(state, list) {
|
||||
Vue.set(state, list.id, list)
|
||||
state[list.id] = list
|
||||
},
|
||||
setLists(state, lists) {
|
||||
lists.forEach(l => {
|
||||
Vue.set(state, l.id, l)
|
||||
state[l.id] = l
|
||||
})
|
||||
},
|
||||
removeListById(state, list) {
|
||||
|
@ -1,5 +1,3 @@
|
||||
import Vue from 'vue'
|
||||
|
||||
import NamespaceService from '../../services/namespace'
|
||||
import {setLoading} from '@/store/helper'
|
||||
|
||||
@ -19,11 +17,13 @@ export default {
|
||||
return
|
||||
}
|
||||
|
||||
// FIXME: direct manipulation of the prop
|
||||
// might not be a problem since this is happening in the mutation
|
||||
if (!namespace.lists || namespace.lists.length === 0) {
|
||||
namespace.lists = state.namespaces[namespaceIndex].lists
|
||||
}
|
||||
|
||||
Vue.set(state.namespaces, namespaceIndex, namespace)
|
||||
|
||||
state.namespaces[namespaceIndex] = namespace
|
||||
},
|
||||
setListInNamespaceById(state, list) {
|
||||
for (const n in state.namespaces) {
|
||||
@ -34,7 +34,7 @@ export default {
|
||||
if (state.namespaces[n].lists[l].id === list.id) {
|
||||
const namespace = state.namespaces[n]
|
||||
namespace.lists[l] = list
|
||||
Vue.set(state.namespaces, n, namespace)
|
||||
state.namespaces[n] = namespace
|
||||
return
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user