Return iso dates for everything date related from the api (#130)

Remove traces of unix timestamp

Revert renaming reminder table column

Fix staticcheck

Remove unused table call

Add migration for renaming reminders table

Fix issues with using TimeStamp

Fix lint

Updated all created / updated fields to use TimeStamps

Add comments

Convert all created / updated fields to datetime

Add time util package

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/api/pulls/130

pkg/routes/caldav/listStorageProvider.go

@@ -342,12 +342,12 @@ func (vlra *VikunjaListResourceAdapter) CalculateEtag() string {
 
 	// Return the etag of a task if we have one
 	if vlra.task != nil {
-		return `"` + strconv.FormatInt(vlra.task.ID, 10) + `-` + strconv.FormatInt(vlra.task.Updated, 10) + `"`
+		return `"` + strconv.FormatInt(vlra.task.ID, 10) + `-` + strconv.FormatInt(vlra.task.Updated.ToTime().Unix(), 10) + `"`
 	}
 	// This also returns the etag of the list, and not of the task,
 	// which becomes problematic because the client uses this etag (= the one from the list) to make
 	// Requests to update a task. These do not match and thus updating a task fails.
-	return `"` + strconv.FormatInt(vlra.list.ID, 10) + `-` + strconv.FormatInt(vlra.list.Updated, 10) + `"`
+	return `"` + strconv.FormatInt(vlra.list.ID, 10) + `-` + strconv.FormatInt(vlra.list.Updated.ToTime().Unix(), 10) + `"`
 }
 
 // GetContent returns the content string of a resource (a task in our case)
@@ -372,11 +372,11 @@ func (vlra *VikunjaListResourceAdapter) GetContentSize() int64 {
 // GetModTime returns when the resource was last modified
 func (vlra *VikunjaListResourceAdapter) GetModTime() time.Time {
 	if vlra.task != nil {
-		return time.Unix(vlra.task.Updated, 0)
+		return time.Unix(vlra.task.Updated.ToTime().Unix(), 0)
 	}
 
 	if vlra.list != nil {
-		return time.Unix(vlra.list.Updated, 0)
+		return time.Unix(vlra.list.Updated.ToTime().Unix(), 0)
 	}
 
 	return time.Time{}

pkg/routes/caldav/parsing.go

@@ -20,6 +20,7 @@ import (
 	"code.vikunja.io/api/pkg/caldav"
 	"code.vikunja.io/api/pkg/log"
 	"code.vikunja.io/api/pkg/models"
+	"code.vikunja.io/api/pkg/timeutil"
 	"github.com/laurent22/ical-go"
 	"strconv"
 	"time"
@@ -31,23 +32,22 @@ func getCaldavTodosForTasks(list *models.List) string {
 	var caldavtodos []*caldav.Todo
 	for _, t := range list.Tasks {
 
-		durationString := t.EndDateUnix - t.StartDateUnix
-		duration, _ := time.ParseDuration(strconv.FormatInt(durationString, 10) + `s`)
+		duration := t.EndDate.ToTime().Sub(t.StartDate.ToTime())
 
 		caldavtodos = append(caldavtodos, &caldav.Todo{
-			TimestampUnix: t.Updated,
-			UID:           t.UID,
-			Summary:       t.Text,
-			Description:   t.Description,
-			CompletedUnix: t.DoneAtUnix,
+			Timestamp:   t.Updated,
+			UID:         t.UID,
+			Summary:     t.Text,
+			Description: t.Description,
+			Completed:   t.DoneAt,
 			// Organizer:     &t.CreatedBy, // Disabled until we figure out how this works
-			Priority:    t.Priority,
-			StartUnix:   t.StartDateUnix,
-			EndUnix:     t.EndDateUnix,
-			CreatedUnix: t.Created,
-			UpdatedUnix: t.Updated,
-			DueDateUnix: t.DueDateUnix,
-			Duration:    duration,
+			Priority: t.Priority,
+			Start:    t.StartDate,
+			End:      t.EndDate,
+			Created:  t.Created,
+			Updated:  t.Updated,
+			DueDate:  t.DueDate,
+			Duration: duration,
 		})
 	}
 
@@ -90,36 +90,36 @@ func parseTaskFromVTODO(content string) (vTask *models.Task, err error) {
 	duration, _ := time.ParseDuration(task["DURATION"])
 
 	vTask = &models.Task{
-		UID:           task["UID"],
-		Text:          task["SUMMARY"],
-		Description:   task["DESCRIPTION"],
-		Priority:      priority,
-		DueDateUnix:   caldavTimeToUnixTimestamp(task["DUE"]),
-		Updated:       caldavTimeToUnixTimestamp(task["DTSTAMP"]),
-		StartDateUnix: caldavTimeToUnixTimestamp(task["DTSTART"]),
-		DoneAtUnix:    caldavTimeToUnixTimestamp(task["COMPLETED"]),
+		UID:         task["UID"],
+		Text:        task["SUMMARY"],
+		Description: task["DESCRIPTION"],
+		Priority:    priority,
+		DueDate:     caldavTimeToTimestamp(task["DUE"]),
+		Updated:     caldavTimeToTimestamp(task["DTSTAMP"]),
+		StartDate:   caldavTimeToTimestamp(task["DTSTART"]),
+		DoneAt:      caldavTimeToTimestamp(task["COMPLETED"]),
 	}
 
 	if task["STATUS"] == "COMPLETED" {
 		vTask.Done = true
 	}
 
-	if duration > 0 && vTask.StartDateUnix > 0 {
-		vTask.EndDateUnix = vTask.StartDateUnix + int64(duration.Seconds())
+	if duration > 0 && vTask.StartDate > 0 {
+		vTask.EndDate = timeutil.FromTime(vTask.StartDate.ToTime().Add(duration))
 	}
 
 	return
 }
 
-func caldavTimeToUnixTimestamp(tstring string) int64 {
+func caldavTimeToTimestamp(tstring string) timeutil.TimeStamp {
 	if tstring == "" {
 		return 0
 	}
 
 	t, err := time.Parse(caldav.DateFormat, tstring)
 	if err != nil {
-		log.Warningf("Error while parsing caldav time %s to unix time: %s", tstring, err)
+		log.Warningf("Error while parsing caldav time %s to TimeStamp: %s", tstring, err)
 		return 0
 	}
-	return t.Unix()
+	return timeutil.FromTime(t)
 }