ami/tl-vikunja
1
0
Fork 0
Code Activity

Improve memory usage of dump by not loading all files in memory prior to adding them to the zip

Browse Source
This commit is contained in:
kolaente
2020-06-20 11:48:45 +02:00
parent c12bac0c96
commit db0126968a
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/modules/dump/dump.go
View File

@ -80,11 +80,20 @@ func Dump(filename string) error {
if err != nil {
return fmt.Errorf("error saving file: %s", err)
}
for fid, fcontent := range allFiles {
err = writeBytesToZip("files/"+strconv.FormatInt(fid, 10), fcontent, dumpWriter)
for fid, file := range allFiles {
header := &zip.FileHeader{
Name: "files/" + strconv.FormatInt(fid, 10),
Method: compressionUsed,
}
w, err := dumpWriter.CreateHeader(header)
if err != nil {
return err
}
_, err = io.Copy(w, file)
if err != nil {
return fmt.Errorf("error writing file %d: %s", fid, err)
}
_ = file.Close()
}
log.Infof("Dumped files")