ami/tl-vikunja
1
0
Fork 0
Code Activity

Improve memory usage of dump by not loading all files in memory prior to adding them to the zip

Browse Source
This commit is contained in:
kolaente
2020-06-20 11:48:45 +02:00
parent c12bac0c96
commit db0126968a
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/files/dump.go
View File

@ -16,27 +16,25 @@
package files
import "bytes"
import (
"io"
)
// Dump dumps all saved files
// This only includes the raw files, no db entries.
func Dump() (allFiles map[int64][]byte, err error) {
func Dump() (allFiles map[int64]io.ReadCloser, err error) {
files := []*File{}
err = x.Find(&files)
if err != nil {
return
}
allFiles = make(map[int64][]byte, len(files))
allFiles = make(map[int64]io.ReadCloser, len(files))
for _, file := range files {
if err := file.LoadFileByID(); err != nil {
return nil, err
}
var buf bytes.Buffer
if _, err := buf.ReadFrom(file.File); err != nil {
return nil, err
}
allFiles[file.ID] = buf.Bytes()
allFiles[file.ID] = file.File
}
return