From ccb708a56f283e957c71c165190d0f415a9788e5 Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 13 Mar 2024 18:42:55 +0100
Subject: [PATCH] fix(reminders): emit reminder changes at the correct time
 (and make sure they are actually emitted)

Resolves https://github.com/go-vikunja/vikunja/issues/225
---
 .../src/components/tasks/partials/reminder-detail.vue     | 8 +++++---
 .../src/components/tasks/partials/reminder-period.vue     | 5 ++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/frontend/src/components/tasks/partials/reminder-detail.vue b/frontend/src/components/tasks/partials/reminder-detail.vue
index e60ca92a8..556d21f4d 100644
--- a/frontend/src/components/tasks/partials/reminder-detail.vue
+++ b/frontend/src/components/tasks/partials/reminder-detail.vue
@@ -73,10 +73,10 @@
 <script setup lang="ts">
 import {computed, ref, watch} from 'vue'
 import {SECONDS_A_DAY, SECONDS_A_HOUR} from '@/constants/date'
-import {IReminderPeriodRelativeTo, REMINDER_PERIOD_RELATIVE_TO_TYPES} from '@/types/IReminderPeriodRelativeTo'
+import {type IReminderPeriodRelativeTo, REMINDER_PERIOD_RELATIVE_TO_TYPES} from '@/types/IReminderPeriodRelativeTo'
 import {useI18n} from 'vue-i18n'
 
-import {PeriodUnit, secondsToPeriod} from '@/helpers/time/period'
+import {type PeriodUnit, secondsToPeriod} from '@/helpers/time/period'
 import type {ITaskReminder} from '@/modelTypes/ITaskReminder'
 import {formatDateShort} from '@/helpers/time/formatDate'
 
@@ -87,6 +87,7 @@ import Popup from '@/components/misc/popup.vue'
 import TaskReminderModel from '@/models/taskReminder'
 import Card from '@/components/misc/card.vue'
 import SimpleButton from '@/components/input/SimpleButton.vue'
+import {useDebounceFn} from '@vueuse/core'
 
 const {
 	modelValue,
@@ -181,8 +182,9 @@ function setReminderFromPreset(preset, close) {
 	close()
 }
 
+const updateDataDebounced = useDebounceFn(updateData, 1000)
 function updateDataAndMaybeClose(close) {
-	updateData()
+	updateDataDebounced()
 	if (clearAfterUpdate) {
 		close()
 	}
diff --git a/frontend/src/components/tasks/partials/reminder-period.vue b/frontend/src/components/tasks/partials/reminder-period.vue
index 919e32825..66f854385 100644
--- a/frontend/src/components/tasks/partials/reminder-period.vue
+++ b/frontend/src/components/tasks/partials/reminder-period.vue
@@ -71,8 +71,7 @@ import {periodToSeconds, PeriodUnit, secondsToPeriod} from '@/helpers/time/perio
 import TaskReminderModel from '@/models/taskReminder'
 
 import type {ITaskReminder} from '@/modelTypes/ITaskReminder'
-import {REMINDER_PERIOD_RELATIVE_TO_TYPES, type IReminderPeriodRelativeTo} from '@/types/IReminderPeriodRelativeTo'
-import {useDebounceFn} from '@vueuse/core'
+import {type IReminderPeriodRelativeTo, REMINDER_PERIOD_RELATIVE_TO_TYPES} from '@/types/IReminderPeriodRelativeTo'
 
 const {
 	modelValue,
@@ -123,7 +122,7 @@ function updateData() {
 	reminder.value.relativeTo = period.value.relativeTo
 	reminder.value.reminder = null
 
-	useDebounceFn(() => emit('update:modelValue', reminder.value), 1000)
+	emit('update:modelValue', reminder.value)
 }
 </script>