ami/tl-vikunja
1
0
Fork 0
Code

fix(migration): don't try to fetch task details of tasks whose projects are deleted

Browse Source
This commit is contained in:
kolaente 2023-04-04 11:24:59 +02:00
parent 84933c08cc
commit c45ad112a2
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/modules/migration/todoist/todoist.go
View File

@ -581,6 +581,14 @@ func (m *Migration) Migrate(u *user.User) (err error) {
}) })
for _, i := range completedSyncResponse.Items { for _, i := range completedSyncResponse.Items {
// Don't try to fetch task details from deleted projects (that will fail anyway)
_, hasProject := completedSyncResponse.Projects[i.ProjectID]
if hasProject && completedSyncResponse.Projects[i.ProjectID].IsDeleted {
log.Debugf("[Todoist Migration] Not fetching task details from task %s because its project (%s) is deleted already.", i.TaskID, i.ProjectID)
continue
}
if _, has := doneItems[i.TaskID]; has { if _, has := doneItems[i.TaskID]; has {
// Only set the newest completion date // Only set the newest completion date
continue continue
@ -599,6 +607,9 @@ func (m *Migration) Migrate(u *user.User) (err error) {
if resp.StatusCode == http.StatusNotFound { if resp.StatusCode == http.StatusNotFound {
// Done items of deleted projects may show up here but since the project is already deleted // Done items of deleted projects may show up here but since the project is already deleted
// we can't show them individually and the api returns a 404. // we can't show them individually and the api returns a 404.
buf := bytes.Buffer{}
_, _ = buf.ReadFrom(resp.Body)
log.Debugf("[Todoist Migration] Could not retrieve task details for task %d: %s", i.TaskID, buf.String())
continue continue
} }
@ -607,11 +618,11 @@ func (m *Migration) Migrate(u *user.User) (err error) {
if err != nil { if err != nil {
return return
} }
log.Debugf("[Todoist Migration] Retrieved full task data for done task %s", i.ID) log.Debugf("[Todoist Migration] Retrieved full task data for done task %s", i.TaskID)
syncResponse.Items = append(syncResponse.Items, doneI.Item) syncResponse.Items = append(syncResponse.Items, doneI.Item)
} }
if len(completedSyncResponse.Items) < 200 { if len(completedSyncResponse.Items) < paginationLimit {
break break
} }
offset++ offset++