From bea81f83f79f7f428ce008bef57f31eae0fc661d Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 18 Jul 2024 15:38:29 +0200
Subject: [PATCH] fix(filters): only insert task buckets and positions when
 there are any

---
 pkg/models/saved_filters.go | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/pkg/models/saved_filters.go b/pkg/models/saved_filters.go
index d55105afb..ac4b4f0a2 100644
--- a/pkg/models/saved_filters.go
+++ b/pkg/models/saved_filters.go
@@ -257,13 +257,15 @@ func (sf *SavedFilter) Update(s *xorm.Session, _ web.Auth) error {
 		}
 	}
 
-	_, err = s.Insert(taskBuckets)
-	if err != nil {
-		return err
-	}
-	_, err = s.Insert(taskPositions)
-	if err != nil {
-		return err
+	if len(taskBuckets) > 0 && len(taskPositions) > 0 {
+		_, err = s.Insert(taskBuckets)
+		if err != nil {
+			return err
+		}
+		_, err = s.Insert(taskPositions)
+		if err != nil {
+			return err
+		}
 	}
 
 	return nil