ami/tl-vikunja
1
0
Fork 0
Code

fix(migration): import card comments from Trello when migrating

Browse Source 
Related: https://community.vikunja.io/t/trello-import-comments-and-assignments/2174/3
This commit is contained in:
kolaente 2024-04-09 13:55:17 +02:00
parent 994aaeb920
commit bc19a2fb78
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
2 changed files with 45 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
pkg/modules/migration/trello/trello.go
View File

@ -180,6 +180,13 @@ func fillCardData(client *trello.Client, board *trello.Board) (err error) {
} }
} }
if card.Badges.Comments > 0 {
card.Actions, err = card.GetCommentActions()
if err != nil {
return
}
}
if len(card.IDCheckLists) > 0 { if len(card.IDCheckLists) > 0 {
for _, checkListID := range card.IDCheckLists { for _, checkListID := range card.IDCheckLists {
checklist, err := client.GetChecklist(checkListID, allArg) checklist, err := client.GetChecklist(checkListID, allArg)
@ -218,7 +225,7 @@ func convertMarkdownToHTML(input string) (output string, err error) {
// Converts all previously obtained data from trello into the vikunja format. // Converts all previously obtained data from trello into the vikunja format.
// `trelloData` should contain all boards with their projects and cards respectively. // `trelloData` should contain all boards with their projects and cards respectively.
func convertTrelloDataToVikunja(organizationName string, trelloData []*trello.Board, token string) (fullVikunjaHierachie []*models.ProjectWithTasksAndBuckets, err error) { func convertTrelloDataToVikunja(organizationName string, trelloData []*trello.Board, token string, currentMember *trello.Member) (fullVikunjaHierachie []*models.ProjectWithTasksAndBuckets, err error) {
log.Debugf("[Trello Migration] ") log.Debugf("[Trello Migration] ")
@ -274,9 +281,11 @@ func convertTrelloDataToVikunja(organizationName string, trelloData []*trello.Bo
log.Debugf("[Trello Migration] Converting card %s", card.ID) log.Debugf("[Trello Migration] Converting card %s", card.ID)
// The usual stuff: Title, description, position, bucket id // The usual stuff: Title, description, position, bucket id
task := &models.Task{ task := &models.TaskWithComments{
Task: models.Task{
Title: card.Name, Title: card.Name,
BucketID: bucketID, BucketID: bucketID,
},
} }
task.Description, err = convertMarkdownToHTML(card.Desc) task.Description, err = convertMarkdownToHTML(card.Desc)
@ -384,7 +393,32 @@ func convertTrelloDataToVikunja(organizationName string, trelloData []*trello.Bo
task.CoverImageAttachmentID = coverAttachment.ID task.CoverImageAttachmentID = coverAttachment.ID
} }
project.Tasks = append(project.Tasks, &models.TaskWithComments{Task: *task}) for _, action := range card.Actions {
if action.DidCommentCard() {
if task.Comments == nil {
task.Comments = []*models.TaskComment{}
}
comment := &models.TaskComment{
Comment: action.Data.Text,
Created: action.Date,
Updated: action.Date,
}
if currentMember == nil || action.IDMemberCreator != currentMember.ID {
comment.Comment = "*" + action.MemberCreator.FullName + "*:\n\n" + comment.Comment
}
comment.Comment, err = convertMarkdownToHTML(comment.Comment)
if err != nil {
return
}
task.Comments = append(task.Comments, comment)
}
}
project.Tasks = append(project.Tasks, task)
} }
project.Buckets = append(project.Buckets, bucket) project.Buckets = append(project.Buckets, bucket)
@ -449,7 +483,11 @@ func (m *Migration) Migrate(u *user.User) (err error) {
log.Debugf("[Trello Migration] Start converting trello data for user %d for organization %s", u.ID, organizationID) log.Debugf("[Trello Migration] Start converting trello data for user %d for organization %s", u.ID, organizationID)
hierarchy, err := convertTrelloDataToVikunja(orgName, boards, m.Token) currentMember, err := client.GetMyMember(trello.Defaults())
if err != nil {
return err
}
hierarchy, err := convertTrelloDataToVikunja(orgName, boards, client.Token, currentMember)
if err != nil { if err != nil {
return err return err
} }

2
pkg/modules/migration/trello/trello_test.go
View File

@ -454,7 +454,7 @@ func TestConvertTrelloToVikunja(t *testing.T) {
organizationMap := getTrelloOrganizationsWithBoards(trelloData) organizationMap := getTrelloOrganizationsWithBoards(trelloData)
for organizationID, boards := range organizationMap { for organizationID, boards := range organizationMap {
hierarchy, err := convertTrelloDataToVikunja(organizationID, boards, "") hierarchy, err := convertTrelloDataToVikunja(organizationID, boards, "", nil)
require.NoError(t, err) require.NoError(t, err)
assert.NotNil(t, hierarchy) assert.NotNil(t, hierarchy)