ami/tl-vikunja
1
0
Fork 0
Code Activity

fix(list): when list background is removed, delete file from file system and DB (#1372)

Browse Source 
Co-authored-by: testinho.testador <testinho.testador@noreply.kolaente.de>
Reviewed-on: https://kolaente.dev/vikunja/api/pulls/1372
Reviewed-by: konrad <k@knt.li>
Co-authored-by: clos <clos@noreply.kolaente.de>
Co-committed-by: clos <clos@noreply.kolaente.de>
This commit is contained in:
clos
2023-02-01 11:38:23 +00:00
committed by konrad
parent 437960b146
commit afdceb0aff
6 changed files with 112 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
pkg/models/list_test.go
View File

@ -21,6 +21,7 @@ import (
"testing"
"code.vikunja.io/api/pkg/db"
"code.vikunja.io/api/pkg/files"
"code.vikunja.io/api/pkg/user"
"github.com/stretchr/testify/assert"
)
@ -246,17 +247,76 @@ func TestList_CreateOrUpdate(t *testing.T) {
}
func TestList_Delete(t *testing.T) {
db.LoadAndAssertFixtures(t)
s := db.NewSession()
list := List{
ID: 1,
}
err := list.Delete(s, &user.User{ID: 1})
assert.NoError(t, err)
err = s.Commit()
assert.NoError(t, err)
db.AssertMissing(t, "lists", map[string]interface{}{
"id": 1,
t.Run("normal", func(t *testing.T) {
db.LoadAndAssertFixtures(t)
s := db.NewSession()
list := List{
ID: 1,
}
err := list.Delete(s, &user.User{ID: 1})
assert.NoError(t, err)
err = s.Commit()
assert.NoError(t, err)
db.AssertMissing(t, "lists", map[string]interface{}{
"id": 1,
})
})
t.Run("with background", func(t *testing.T) {
db.LoadAndAssertFixtures(t)
files.InitTestFileFixtures(t)
s := db.NewSession()
list := List{
ID: 25,
}
err := list.Delete(s, &user.User{ID: 6})
assert.NoError(t, err)
err = s.Commit()
assert.NoError(t, err)
db.AssertMissing(t, "lists", map[string]interface{}{
"id": 25,
})
db.AssertMissing(t, "files", map[string]interface{}{
"id": 1,
})
})
}
func TestList_DeleteBackgroundFileIfExists(t *testing.T) {
t.Run("list with background", func(t *testing.T) {
db.LoadAndAssertFixtures(t)
files.InitTestFileFixtures(t)
s := db.NewSession()
file := &files.File{ID: 1}
list := List{
ID: 1,
BackgroundFileID: file.ID,
}
err := SetListBackground(s, list.ID, file, "")
assert.NoError(t, err)
err = list.DeleteBackgroundFileIfExists()
assert.NoError(t, err)
})
t.Run("list with invalid background", func(t *testing.T) {
db.LoadAndAssertFixtures(t)
files.InitTestFileFixtures(t)
s := db.NewSession()
file := &files.File{ID: 9999}
list := List{
ID: 1,
BackgroundFileID: file.ID,
}
err := SetListBackground(s, list.ID, file, "")
assert.NoError(t, err)
err = list.DeleteBackgroundFileIfExists()
assert.Error(t, err)
assert.True(t, files.IsErrFileDoesNotExist(err))
})
t.Run("list without background", func(t *testing.T) {
db.LoadAndAssertFixtures(t)
files.InitTestFileFixtures(t)
list := List{ID: 1}
err := list.DeleteBackgroundFileIfExists()
assert.NoError(t, err)
})
}