From ae001c6ca716175334a6516cc51a622df58a64ed Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 11 Oct 2023 19:07:11 +0200
Subject: [PATCH] fix(user): allow openid users to request their deletion

Resolves https://community.vikunja.io/t/delete-user-not-possible-when-using-oidc/1689/4
---
 src/i18n/lang/en.json                |  2 +
 src/views/user/settings/Deletion.vue | 69 ++++++++++++++++------------
 2 files changed, 42 insertions(+), 29 deletions(-)

diff --git a/src/i18n/lang/en.json b/src/i18n/lang/en.json
index bf4e263d9..fe5c1ddbb 100644
--- a/src/i18n/lang/en.json
+++ b/src/i18n/lang/en.json
@@ -176,6 +176,7 @@
       "title": "Delete your Vikunja Account",
       "text1": "The deletion of your account is permanent and cannot be undone. We will delete all your projects, tasks and everything associated with it.",
       "text2": "To proceed, please enter your password. You will receive an email with further instructions.",
+      "text3": "To proceed, please press the button below. You will receive an email with further instructions.",
       "confirm": "Delete my account",
       "requestSuccess": "The request was successful. You'll receive an email with further instructions.",
       "passwordRequired": "Please enter your password.",
@@ -183,6 +184,7 @@
       "scheduled": "We will delete your Vikunja account at {date} ({dateSince}).",
       "scheduledCancel": "To cancel the deletion of your account, click here.",
       "scheduledCancelText": "To cancel the deletion of your account, please enter your password below:",
+      "scheduledCancelButton": "To cancel the deletion of your account, please press the button below:",
       "scheduledCancelConfirm": "Cancel the deletion of my account",
       "scheduledCancelSuccess": "We will not delete your account."
     },
diff --git a/src/views/user/settings/Deletion.vue b/src/views/user/settings/Deletion.vue
index 5d855d1af..4e335ad77 100644
--- a/src/views/user/settings/Deletion.vue
+++ b/src/views/user/settings/Deletion.vue
@@ -10,29 +10,34 @@
 						})
 					}}
 				</p>
-				<p>
-					{{ $t('user.deletion.scheduledCancelText') }}
-				</p>
-				<div class="field">
-					<label class="label" for="currentPasswordAccountDelete">
-						{{ $t('user.settings.currentPassword') }}
-					</label>
-					<div class="control">
-						<input
-							class="input"
-							:class="{'is-danger': errPasswordRequired}"
-							id="currentPasswordAccountDelete"
-							:placeholder="$t('user.settings.currentPasswordPlaceholder')"
-							type="password"
-							v-model="password"
-							@keyup="() => errPasswordRequired = password === ''"
-							ref="passwordInput"
-						/>
-					</div>
-					<p class="help is-danger" v-if="errPasswordRequired">
-						{{ $t('user.deletion.passwordRequired') }}
+				<template v-if="isLocalUser">
+					<p>
+						{{ $t('user.deletion.scheduledCancelText') }}
 					</p>
-				</div>
+					<div class="field">
+						<label class="label" for="currentPasswordAccountDelete">
+							{{ $t('user.settings.currentPassword') }}
+						</label>
+						<div class="control">
+							<input
+								class="input"
+								:class="{'is-danger': errPasswordRequired}"
+								id="currentPasswordAccountDelete"
+								:placeholder="$t('user.settings.currentPasswordPlaceholder')"
+								type="password"
+								v-model="password"
+								@keyup="() => errPasswordRequired = password === ''"
+								ref="passwordInput"
+							/>
+						</div>
+						<p class="help is-danger" v-if="errPasswordRequired">
+							{{ $t('user.deletion.passwordRequired') }}
+						</p>
+					</div>
+				</template>
+				<p v-else>
+					{{ $t('user.deletion.scheduledCancelButton') }}
+				</p>
 			</form>
 
 			<x-button
@@ -43,10 +48,10 @@
 			</x-button>
 		</template>
 		<template v-else>
-			<form @submit.prevent="deleteAccount()">
-				<p>
-					{{ $t('user.deletion.text1') }}
-				</p>
+			<p>
+				{{ $t('user.deletion.text1') }}
+			</p>
+			<form @submit.prevent="deleteAccount()" v-if="isLocalUser">
 				<p>
 					{{ $t('user.deletion.text2') }}
 				</p>
@@ -71,6 +76,9 @@
 					</p>
 				</div>
 			</form>
+			<p v-else>
+				{{ $t('user.deletion.text3') }}
+			</p>
 
 			<x-button
 				:loading="accountDeleteService.loading"
@@ -83,7 +91,7 @@
 </template>
 
 <script lang="ts">
-export default { name: 'user-settings-deletion' }
+export default {name: 'user-settings-deletion'}
 </script>
 
 <script setup lang="ts">
@@ -111,9 +119,12 @@ const configStore = useConfigStore()
 const userDeletionEnabled = computed(() => configStore.userDeletionEnabled)
 const deletionScheduledAt = computed(() => parseDateOrNull(authStore.info?.deletionScheduledAt))
 
+const isLocalUser = computed(() => authStore.info?.isLocalUser)
+
 const passwordInput = ref()
+
 async function deleteAccount() {
-	if (password.value === '') {
+	if (isLocalUser.value && password.value === '') {
 		errPasswordRequired.value = true
 		passwordInput.value.focus()
 		return
@@ -125,7 +136,7 @@ async function deleteAccount() {
 }
 
 async function cancelDeletion() {
-	if (password.value === '') {
+	if (isLocalUser.value && password.value === '') {
 		errPasswordRequired.value = true
 		passwordInput.value.focus()
 		return