fix(task): delete the task after all related attributes to prevent task not found errors
This commit is contained in:
parent
1630e4fc08
commit
a20f6ac815
@ -1432,10 +1432,6 @@ func (t *Task) Delete(s *xorm.Session, a web.Auth) (err error) {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
if _, err = s.ID(t.ID).Delete(Task{}); err != nil {
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
|
|
||||||
// Delete assignees
|
// Delete assignees
|
||||||
if _, err = s.Where("task_id = ?", t.ID).Delete(TaskAssginee{}); err != nil {
|
if _, err = s.Where("task_id = ?", t.ID).Delete(TaskAssginee{}); err != nil {
|
||||||
return err
|
return err
|
||||||
@ -1484,6 +1480,12 @@ func (t *Task) Delete(s *xorm.Session, a web.Auth) (err error) {
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Actually delete the task
|
||||||
|
_, err = s.ID(t.ID).Delete(Task{})
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
doer, _ := user.GetFromAuth(a)
|
doer, _ := user.GetFromAuth(a)
|
||||||
err = events.Dispatch(&TaskDeletedEvent{
|
err = events.Dispatch(&TaskDeletedEvent{
|
||||||
Task: fullTask,
|
Task: fullTask,
|
||||||
|
Loading…
x
Reference in New Issue
Block a user