ami/tl-vikunja
1
0
Fork 0
Code

feat: remove props destructuring from SingleTaskInProject

Browse Source
This commit is contained in:
Dominik Pschenitschni 2024-07-05 15:27:36 +02:00 committed by konrad
parent 871e0acd8a
commit a15831eb33
1 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
frontend/src/components/tasks/partials/SingleTaskInProject.vue
View File

@ -208,30 +208,31 @@ import {playPopSound} from '@/helpers/playPop'
import {isEditorContentEmpty} from '@/helpers/editorContentEmpty' import {isEditorContentEmpty} from '@/helpers/editorContentEmpty'
import {TASK_REPEAT_MODES} from '@/types/IRepeatMode' import {TASK_REPEAT_MODES} from '@/types/IRepeatMode'
const { const props = withDefaults(defineProps<{
theTask,
isArchived = false,
showProject = false,
disabled = false,
canMarkAsDone = true,
allTasks = [],
} = defineProps<{
theTask: ITask, theTask: ITask,
isArchived?: boolean, isArchived?: boolean,
showProject?: boolean, showProject?: boolean,
disabled?: boolean, disabled?: boolean,
canMarkAsDone?: boolean, canMarkAsDone?: boolean,
allTasks?: ITask[], allTasks?: ITask[],
}>(), {
isArchived: false,
showProject: false,
disabled: false,
canMarkAsDone: true,
allTasks: () => [],
})
const emit = defineEmits<{
'taskUpdated': [task: ITask],
}>() }>()
const emit = defineEmits(['taskUpdated'])
function getTaskById(taskId: number): ITask | undefined { function getTaskById(taskId: number): ITask | undefined {
if (typeof allTasks === 'undefined' || allTasks.length === 0) { if (typeof props.allTasks === 'undefined' || props.allTasks.length === 0) {
return null return null
} }
return allTasks.find(t => t.id === taskId) return props.allTasks.find(t => t.id === taskId)
} }
const {t} = useI18n({useScope: 'global'}) const {t} = useI18n({useScope: 'global'})
@ -243,14 +244,17 @@ const showDefer = ref(false)
const isRepeating = computed(() => task.value.repeatAfter.amount > 0 || (task.value.repeatAfter.amount === 0 && task.value.repeatMode === TASK_REPEAT_MODES.REPEAT_MODE_MONTH)) const isRepeating = computed(() => task.value.repeatAfter.amount > 0 || (task.value.repeatAfter.amount === 0 && task.value.repeatMode === TASK_REPEAT_MODES.REPEAT_MODE_MONTH))
watch( watch(
() => theTask, () => props.theTask,
newVal => { newVal => {
task.value = newVal task.value = newVal
}, },
{
immediate: true,
deep: true,
},
) )
onMounted(() => { onMounted(() => {
task.value = theTask
document.addEventListener('click', hideDeferDueDatePopup) document.addEventListener('click', hideDeferDueDatePopup)
}) })
@ -265,7 +269,7 @@ const taskStore = useTaskStore()
const project = computed(() => projectStore.projects[task.value.projectId]) const project = computed(() => projectStore.projects[task.value.projectId])
const projectColor = computed(() => project.value ? project.value?.hexColor : '') const projectColor = computed(() => project.value ? project.value?.hexColor : '')
const showProjectSeparately = computed(() => !showProject && currentProject.value?.id !== task.value.projectId && project.value) const showProjectSeparately = computed(() => !props.showProject && currentProject.value?.id !== task.value.projectId && project.value)
const currentProject = computed(() => { const currentProject = computed(() => {
return typeof baseStore.currentProject === 'undefined' ? { return typeof baseStore.currentProject === 'undefined' ? {