From 9fd17aca1813087e98b4d5e5a758b7e62482d3d9 Mon Sep 17 00:00:00 2001 From: Dominik Pschenitschni Date: Tue, 11 Jun 2024 20:36:47 +0000 Subject: [PATCH] fix: useTitle types (#2369) Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2369 Co-authored-by: Dominik Pschenitschni Co-committed-by: Dominik Pschenitschni --- frontend/src/composables/useTitle.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/frontend/src/composables/useTitle.ts b/frontend/src/composables/useTitle.ts index 6dc398a1e..a0ed0d622 100644 --- a/frontend/src/composables/useTitle.ts +++ b/frontend/src/composables/useTitle.ts @@ -1,15 +1,15 @@ import {computed} from 'vue' -import type {Ref} from 'vue' -import {useTitle as useTitleVueUse, toRef} from '@vueuse/core' +import {useTitle as useTitleVueUse, toValue, type UseTitleOptions, type ReadonlyRefOrGetter, type MaybeRef, type MaybeRefOrGetter} from '@vueuse/core' -type UseTitleParameters = Parameters - -export function useTitle(...args: UseTitleParameters) { - - const [newTitle, ...restArgs] = args - - const pageTitle = toRef(newTitle) as Ref +export function useTitle( + newTitle: + | ReadonlyRefOrGetter + | MaybeRef + | MaybeRefOrGetter = null, + options?: UseTitleOptions, +) { + const pageTitle = computed(() => toValue(newTitle)) const completeTitle = computed(() => (typeof pageTitle.value === 'undefined' || pageTitle.value === '') @@ -17,5 +17,5 @@ export function useTitle(...args: UseTitleParameters) { : `${pageTitle.value} | Vikunja`, ) - return useTitleVueUse(completeTitle, ...restArgs) + return useTitleVueUse(completeTitle, options) } \ No newline at end of file