From 92f2e0e214e7d611820354e107ba6411e549d959 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <mail@celement.de>
Date: Sat, 15 Jun 2024 16:59:31 +0200
Subject: [PATCH] feat: improve popup

---
 frontend/src/components/misc/popup.vue | 34 +++++++++++---------------
 1 file changed, 14 insertions(+), 20 deletions(-)

diff --git a/frontend/src/components/misc/popup.vue b/frontend/src/components/misc/popup.vue
index 24b8235e8..da8dd309b 100644
--- a/frontend/src/components/misc/popup.vue
+++ b/frontend/src/components/misc/popup.vue
@@ -10,7 +10,7 @@
 		class="popup"
 		:class="{
 			'is-open': openValue,
-			'has-overflow': props.hasOverflow && openValue
+			'has-overflow': hasOverflow && openValue
 		}"
 	>
 		<slot
@@ -23,31 +23,23 @@
 </template>
 
 <script setup lang="ts">
-import {ref, watch} from 'vue'
+import {ref, watchEffect} from 'vue'
 import {onClickOutside} from '@vueuse/core'
 
-const props = defineProps({
-	hasOverflow: {
-		type: Boolean,
-		default: false,
-	},
-	open: {
-		type: Boolean,
-		default: false,
-	},
+const props = withDefaults(defineProps<{
+	hasOverflow?: boolean
+	open?: boolean
+}>(), {
+	hasOverflow: false,
+	open: false,
 })
 
 const emit = defineEmits(['close'])
 
-watch(
-	() => props.open,
-	nowOpen => {
-		openValue.value = nowOpen
-	},
-)
-
-const openValue = ref(false)
-const popup = ref<HTMLElement | null>(null)
+const openValue = ref(props.open)
+watchEffect(() => {
+	openValue.value = props.open
+})
 
 function close() {
 	openValue.value = false
@@ -58,6 +50,8 @@ function toggle() {
 	openValue.value = !openValue.value
 }
 
+const popup = ref<HTMLElement | null>(null)
+
 onClickOutside(popup, () => {
 	if (!openValue.value) {
 		return