ami/tl-vikunja
1
0
Fork 0
Code

fix(views): use correct assertion in test

Browse Source
This commit is contained in:
kolaente 2024-04-02 12:42:07 +02:00
parent 81fe8391e4
commit 8a6e3d5bd7
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
3 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pkg/models/kanban.go
View File

@ -384,27 +384,27 @@ func (b *Bucket) Delete(s *xorm.Session, a web.Auth) (err error) {
} }
// Get the default bucket // Get the default bucket
p, err := GetProjectViewByIDAndProject(s, b.ProjectViewID, b.ProjectID) pv, err := GetProjectViewByIDAndProject(s, b.ProjectViewID, b.ProjectID)
if err != nil { if err != nil {
return return
} }
var updateProject bool var updateProjectView bool
if b.ID == p.DefaultBucketID { if b.ID == pv.DefaultBucketID {
p.DefaultBucketID = 0 pv.DefaultBucketID = 0
updateProject = true updateProjectView = true
} }
if b.ID == p.DoneBucketID { if b.ID == pv.DoneBucketID {
p.DoneBucketID = 0 pv.DoneBucketID = 0
updateProject = true updateProjectView = true
} }
if updateProject { if updateProjectView {
err = p.Update(s, a) err = pv.Update(s, a)
if err != nil { if err != nil {
return return
} }
} }
defaultBucketID, err := getDefaultBucketID(s, p) defaultBucketID, err := getDefaultBucketID(s, pv)
if err != nil { if err != nil {
return err return err
} }

4
pkg/models/kanban_test.go
View File

@ -216,10 +216,10 @@ func TestBucket_Delete(t *testing.T) {
err := b.Delete(s, u) err := b.Delete(s, u)
require.NoError(t, err) require.NoError(t, err)
db.AssertMissing(t, "project_views", map[string]interface{}{ db.AssertExists(t, "project_views", map[string]interface{}{
"id": b.ProjectViewID, "id": b.ProjectViewID,
"done_bucket_id": 0, "done_bucket_id": 0,
}) }, false)
}) })
} }

4
pkg/models/project_view.go
View File

@ -344,10 +344,6 @@ func (p *ProjectView) Update(s *xorm.Session, _ web.Auth) (err error) {
"done_bucket_id", "done_bucket_id",
). ).
Update(p) Update(p)
if err != nil {
return
}
return return
} }