chore: cleanup
This commit is contained in:
parent
7cab3a77a9
commit
7a9611c2da
@ -135,7 +135,7 @@ END:VCALENDAR`,
|
|||||||
|
|
||||||
func TestGetCaldavTodosForTasks(t *testing.T) {
|
func TestGetCaldavTodosForTasks(t *testing.T) {
|
||||||
type args struct {
|
type args struct {
|
||||||
list *models.ListWithTasksAndBuckets
|
list *models.ProjectWithTasksAndBuckets
|
||||||
tasks []*models.TaskWithComments
|
tasks []*models.TaskWithComments
|
||||||
}
|
}
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
@ -146,8 +146,8 @@ func TestGetCaldavTodosForTasks(t *testing.T) {
|
|||||||
{
|
{
|
||||||
name: "Format single Task as Caldav",
|
name: "Format single Task as Caldav",
|
||||||
args: args{
|
args: args{
|
||||||
list: &models.ListWithTasksAndBuckets{
|
list: &models.ProjectWithTasksAndBuckets{
|
||||||
List: models.List{
|
Project: models.Project{
|
||||||
Title: "List title",
|
Title: "List title",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
@ -220,7 +220,7 @@
|
|||||||
updated: 2020-04-18 21:13:52
|
updated: 2020-04-18 21:13:52
|
||||||
- id: 36
|
- id: 36
|
||||||
title: testbucket36
|
title: testbucket36
|
||||||
list_id: 26
|
project_id: 26
|
||||||
created_by_id: 15
|
created_by_id: 15
|
||||||
created: 2020-04-18 21:13:52
|
created: 2020-04-18 21:13:52
|
||||||
updated: 2020-04-18 21:13:52
|
updated: 2020-04-18 21:13:52
|
||||||
|
@ -362,7 +362,7 @@
|
|||||||
priority: 3
|
priority: 3
|
||||||
done: false
|
done: false
|
||||||
created_by_id: 15
|
created_by_id: 15
|
||||||
list_id: 26
|
project_id: 26
|
||||||
index: 39
|
index: 39
|
||||||
due_date: 2023-03-01 15:00:00
|
due_date: 2023-03-01 15:00:00
|
||||||
created: 2018-12-01 01:12:04
|
created: 2018-12-01 01:12:04
|
||||||
|
@ -48,7 +48,7 @@
|
|||||||
created: 2018-12-01 15:13:12
|
created: 2018-12-01 15:13:12
|
||||||
- id: 9
|
- id: 9
|
||||||
user_id: 15
|
user_id: 15
|
||||||
list_id: 26
|
project_id: 26
|
||||||
right: 0
|
right: 0
|
||||||
updated: 2018-12-02 15:13:12
|
updated: 2018-12-02 15:13:12
|
||||||
created: 2018-12-01 15:13:12
|
created: 2018-12-01 15:13:12
|
||||||
|
@ -41,8 +41,8 @@ END:VTODO
|
|||||||
END:VCALENDAR`
|
END:VCALENDAR`
|
||||||
|
|
||||||
func TestCaldav(t *testing.T) {
|
func TestCaldav(t *testing.T) {
|
||||||
t.Run("Delivers VTODO for list", func(t *testing.T) {
|
t.Run("Delivers VTODO for project", func(t *testing.T) {
|
||||||
rec, err := newCaldavTestRequestWithUser(t, http.MethodGet, caldav.ListHandler, &testuser15, ``, nil, map[string]string{"list": "26"})
|
rec, err := newCaldavTestRequestWithUser(t, http.MethodGet, caldav.ProjectHandler, &testuser15, ``, nil, map[string]string{"project": "26"})
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Contains(t, rec.Body.String(), "BEGIN:VCALENDAR")
|
assert.Contains(t, rec.Body.String(), "BEGIN:VCALENDAR")
|
||||||
assert.Contains(t, rec.Body.String(), "PRODID:-//Vikunja Todo App//EN")
|
assert.Contains(t, rec.Body.String(), "PRODID:-//Vikunja Todo App//EN")
|
||||||
@ -52,12 +52,12 @@ func TestCaldav(t *testing.T) {
|
|||||||
assert.Contains(t, rec.Body.String(), "END:VCALENDAR")
|
assert.Contains(t, rec.Body.String(), "END:VCALENDAR")
|
||||||
})
|
})
|
||||||
t.Run("Import VTODO", func(t *testing.T) {
|
t.Run("Import VTODO", func(t *testing.T) {
|
||||||
rec, err := newCaldavTestRequestWithUser(t, http.MethodPut, caldav.TaskHandler, &testuser15, vtodo, nil, map[string]string{"list": "26", "task": "uid"})
|
rec, err := newCaldavTestRequestWithUser(t, http.MethodPut, caldav.TaskHandler, &testuser15, vtodo, nil, map[string]string{"project": "26", "task": "uid"})
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Equal(t, rec.Result().StatusCode, 201)
|
assert.Equal(t, rec.Result().StatusCode, 201)
|
||||||
})
|
})
|
||||||
t.Run("Export VTODO", func(t *testing.T) {
|
t.Run("Export VTODO", func(t *testing.T) {
|
||||||
rec, err := newCaldavTestRequestWithUser(t, http.MethodGet, caldav.TaskHandler, &testuser15, ``, nil, map[string]string{"list": "26", "task": "uid-caldav-test"})
|
rec, err := newCaldavTestRequestWithUser(t, http.MethodGet, caldav.TaskHandler, &testuser15, ``, nil, map[string]string{"project": "26", "task": "uid-caldav-test"})
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
assert.Contains(t, rec.Body.String(), "BEGIN:VCALENDAR")
|
assert.Contains(t, rec.Body.String(), "BEGIN:VCALENDAR")
|
||||||
assert.Contains(t, rec.Body.String(), "SUMMARY:Title Caldav Test")
|
assert.Contains(t, rec.Body.String(), "SUMMARY:Title Caldav Test")
|
||||||
|
@ -1,4 +1,4 @@
|
|||||||
// Vikunja is a to-do project application to facilitate your life.
|
// Vikunja is a to-do list application to facilitate your life.
|
||||||
// Copyright 2018-2021 Vikunja and contributors. All rights reserved.
|
// Copyright 2018-2021 Vikunja and contributors. All rights reserved.
|
||||||
//
|
//
|
||||||
// This program is free software: you can redistribute it and/or modify
|
// This program is free software: you can redistribute it and/or modify
|
||||||
|
@ -1210,7 +1210,7 @@ func (t *Task) Update(s *xorm.Session, a web.Auth) (err error) {
|
|||||||
|
|
||||||
// Update all positions if the newly saved position is < 0.1
|
// Update all positions if the newly saved position is < 0.1
|
||||||
if ot.Position < 0.1 {
|
if ot.Position < 0.1 {
|
||||||
err = recalculateTaskPositions(s, t.ListID)
|
err = recalculateTaskPositions(s, t.ProjectID)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@ -1273,11 +1273,11 @@ func recalculateTaskKanbanPositions(s *xorm.Session, bucketID int64) (err error)
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
func recalculateTaskPositions(s *xorm.Session, listID int64) (err error) {
|
func recalculateTaskPositions(s *xorm.Session, projectID int64) (err error) {
|
||||||
|
|
||||||
allTasks := []*Task{}
|
allTasks := []*Task{}
|
||||||
err = s.
|
err = s.
|
||||||
Where("list_id = ?", listID).
|
Where("project_id = ?", projectID).
|
||||||
OrderBy("position asc").
|
OrderBy("position asc").
|
||||||
Find(&allTasks)
|
Find(&allTasks)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
@ -380,7 +380,7 @@ func TestTask_Update(t *testing.T) {
|
|||||||
time.Unix(1674745156, 0),
|
time.Unix(1674745156, 0),
|
||||||
time.Unix(1674745156, 223),
|
time.Unix(1674745156, 223),
|
||||||
},
|
},
|
||||||
ListID: 1,
|
ProjectID: 1,
|
||||||
}
|
}
|
||||||
err := task.Update(s, u)
|
err := task.Update(s, u)
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
@ -341,7 +341,7 @@ func RemoveProjectBackground(c echo.Context) error {
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
err = list.DeleteBackgroundFileIfExists()
|
err = project.DeleteBackgroundFileIfExists()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user