1
0

Fix error handling when deleting an attachment file

This commit is contained in:
kolaente
2021-07-20 10:14:49 +02:00
parent e4a0066e20
commit 733f26f017
2 changed files with 11 additions and 2 deletions

View File

@ -17,7 +17,9 @@
package files
import (
"code.vikunja.io/api/pkg/log"
"io"
"os"
"strconv"
"time"
@ -129,9 +131,16 @@ func (f *File) Delete() (err error) {
err = afs.Remove(f.getFileName())
if err != nil {
if e, is := err.(*os.PathError); is {
// Don't fail when removing the file failed
log.Errorf("Error deleting file %d: %s", e.Error())
return s.Commit()
}
_ = s.Rollback()
return err
}
return
}