ami/tl-vikunja
1
0
Fork 0
Code Activity

Explicitly check if there are Ids before trying to get items by a list of Ids

Browse Source
This commit is contained in:
kolaente
2021-03-02 18:40:39 +01:00
parent 3999580fe6
commit 6de3d8b3a1
10 changed files with 61 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/models/task_attachment.go
View File

@ -128,6 +128,10 @@ func (ta *TaskAttachment) ReadAll(s *xorm.Session, a web.Auth, search string, pa
return nil, 0, 0, err
}
if len(attachments) == 0 {
return
}
fileIDs := make([]int64, 0, len(attachments))
userIDs := make([]int64, 0, len(attachments))
for _, r := range attachments {
@ -228,9 +232,11 @@ func getTaskAttachmentsByTaskIDs(s *xorm.Session, taskIDs []int64) (attachments
}
users := make(map[int64]*user.User)
err = s.In("id", userIDs).Find(&users)
if err != nil {
return
if len(userIDs) > 0 {
err = s.In("id", userIDs).Find(&users)
if err != nil {
return
}
}
// Obfuscate all user emails