Add Golangci Lint (#676)

Increase golangci timeout

Fix installing golangci-lint in ci

Remove mage targets replaced by golangci

Run golint in ci

Add goheader linter

Enable & fix more linters

Fix lint issues

Add mage target to automagically fix issues found by golangci

golangci-lint run --fix

Add golangci config

Add golangci mage target

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/api/pulls/676
Co-Authored-By: konrad <konrad@kola-entertainments.de>
Co-Committed-By: konrad <konrad@kola-entertainments.de>

pkg/migration/20200420215928.go

@@ -18,6 +18,7 @@ package migration
 
 import (
 	"math"
+
 	"src.techknowlogick.com/xormigrate"
 	"xorm.io/xorm"
 )

pkg/migration/20200516123847.go

@@ -17,8 +17,9 @@
 package migration
 
 import (
-	"src.techknowlogick.com/xormigrate"
 	"strings"
+
+	"src.techknowlogick.com/xormigrate"
 	"xorm.io/xorm"
 )
 
@@ -55,7 +56,7 @@ func init() {
 				// The general idea here is to take the title and slice it into pieces, until we found a unique piece.
 
 				var exists = true
-				titleSlug := []rune(strings.Replace(strings.ToUpper(l.Title), " ", "", -1))
+				titleSlug := []rune(strings.ReplaceAll(strings.ToUpper(l.Title), " ", ""))
 
 				// We can save at most 10 characters in the db, so we need to ensure it has at most 10 characters
 				if len(titleSlug) > 10 {

pkg/migration/20200621214452.go

@@ -18,8 +18,9 @@ package migration
 
 import (
 	"fmt"
-	"src.techknowlogick.com/xormigrate"
 	"strings"
+
+	"src.techknowlogick.com/xormigrate"
 	"xorm.io/xorm"
 	"xorm.io/xorm/schemas"
 )
@@ -654,7 +655,7 @@ create unique index UQE_users_namespace_id
 						// The statement is probably useless anyway since its only purpose is to clean up old tables
 						// which may be leftovers from a previously failed migration. However, since the whole thing
 						// is wrapped in sessions, this is extremely unlikely to happen anyway.
-						//"ALTER TABLE " + table + " DROP COLUMN IF EXISTS " + colTmp + ";",
+						// "ALTER TABLE " + table + " DROP COLUMN IF EXISTS " + colTmp + ";",
 						"ALTER TABLE " + table + " ADD COLUMN " + colTmp + " DATETIME NULL;",
 						// #nosec
 						"UPDATE " + table + " SET " + colTmp + " = IF(" + colOld + " = 0, NULL, FROM_UNIXTIME(" + colOld + "));",

pkg/migration/20200906184746.go

@@ -17,9 +17,10 @@
 package migration
 
 import (
+	"time"
+
 	"code.vikunja.io/api/pkg/models"
 	"src.techknowlogick.com/xormigrate"
-	"time"
 	"xorm.io/xorm"
 )
 

pkg/migration/migration.go

@@ -17,6 +17,9 @@
 package migration
 
 import (
+	"os"
+	"sort"
+
 	"code.vikunja.io/api/pkg/config"
 	"code.vikunja.io/api/pkg/db"
 	"code.vikunja.io/api/pkg/files"
@@ -25,8 +28,6 @@ import (
 	"code.vikunja.io/api/pkg/modules/migration"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/olekukonko/tablewriter"
-	"os"
-	"sort"
 	"src.techknowlogick.com/xormigrate"
 	"xorm.io/xorm"
 )