Add Golangci Lint (#676)

Increase golangci timeout

Fix installing golangci-lint in ci

Remove mage targets replaced by golangci

Run golint in ci

Add goheader linter

Enable & fix more linters

Fix lint issues

Add mage target to automagically fix issues found by golangci

golangci-lint run --fix

Add golangci config

Add golangci mage target

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/api/pulls/676
Co-Authored-By: konrad <konrad@kola-entertainments.de>
Co-Committed-By: konrad <konrad@kola-entertainments.de>

pkg/integrations/archived_test.go

@@ -18,11 +18,12 @@
 package integrations
 
 import (
+	"net/url"
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/stretchr/testify/assert"
-	"net/url"
-	"testing"
 )
 
 // This tests the following behaviour:

pkg/integrations/integrations.go

@@ -17,6 +17,13 @@
 package integrations
 
 import (
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"os"
+	"strings"
+	"testing"
+
 	"code.vikunja.io/api/pkg/config"
 	"code.vikunja.io/api/pkg/db"
 	"code.vikunja.io/api/pkg/files"
@@ -29,12 +36,6 @@ import (
 	"github.com/dgrijalva/jwt-go"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"net/http/httptest"
-	"net/url"
-	"os"
-	"strings"
-	"testing"
 )
 
 // These are the test users, the same way they are in the test database

pkg/integrations/kanban_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestBucket(t *testing.T) {

pkg/integrations/link_sharing_test.go

@@ -17,12 +17,13 @@
 package integrations
 
 import (
+	"net/url"
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/url"
-	"testing"
 )
 
 func TestLinkSharing(t *testing.T) {

pkg/integrations/list_test.go

@@ -17,12 +17,13 @@
 package integrations
 
 import (
+	"net/url"
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/url"
-	"testing"
 )
 
 func TestList(t *testing.T) {

pkg/integrations/login_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestLogin(t *testing.T) {

pkg/integrations/register_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestRegister(t *testing.T) {

pkg/integrations/task_collection_test.go

@@ -18,11 +18,12 @@
 package integrations
 
 import (
+	"net/url"
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/stretchr/testify/assert"
-	"net/url"
-	"testing"
 )
 
 func TestTaskCollection(t *testing.T) {

pkg/integrations/task_comment_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestTaskComments(t *testing.T) {

pkg/integrations/task_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"testing"
+
 	"code.vikunja.io/api/pkg/models"
 	"code.vikunja.io/web/handler"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestTask(t *testing.T) {

pkg/integrations/token_test.go

@@ -17,10 +17,11 @@
 package integrations
 
 import (
-	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"testing"
+
+	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestCheckToken(t *testing.T) {

pkg/integrations/user_change_password_test.go

@@ -17,11 +17,12 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestUserChangePassword(t *testing.T) {

pkg/integrations/user_confirm_email_test.go

@@ -17,12 +17,13 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestUserConfirmEmail(t *testing.T) {

pkg/integrations/user_list_test.go

@@ -17,10 +17,11 @@
 package integrations
 
 import (
-	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"testing"
+
+	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestUserList(t *testing.T) {

pkg/integrations/user_password_request_token_test.go

@@ -17,12 +17,13 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestUserRequestResetPasswordToken(t *testing.T) {

pkg/integrations/user_password_reset_test.go

@@ -17,12 +17,13 @@
 package integrations
 
 import (
+	"net/http"
+	"testing"
+
 	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
 	"code.vikunja.io/api/pkg/user"
 	"github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
-	"net/http"
-	"testing"
 )
 
 func TestUserPasswordReset(t *testing.T) {

pkg/integrations/user_show_test.go

@@ -17,10 +17,11 @@
 package integrations
 
 import (
-	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
-	"github.com/stretchr/testify/assert"
 	"net/http"
 	"testing"
+
+	apiv1 "code.vikunja.io/api/pkg/routes/api/v1"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestUserShow(t *testing.T) {