ami/tl-vikunja
1
0
Fork 0
Code Activity

implemented delete list item via CRUD

Browse Source
This commit is contained in:
konrad
2018-07-11 11:44:17 +02:00
committed by kolaente
parent 281e9c1cd0
commit 5c4fb7ed73
5 changed files with 47 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
models/list_items_create_update.go
View File

@ -23,22 +23,13 @@ func (i *ListItem) Update(ID int64, doer *User) (err error) {
// Helper function for creation or updating of new lists as both methods share most of their logic
func createOrUpdateListItem(i *ListItem, doer *User, lID int64) (err error) {
// Check rights
user, _, err := GetUserByID(doer.ID)
user, err := listItemPreCheck(i, doer, lID)
if err != nil {
return
}
// Get the list to check if the user has the right to write to that list
list, err := GetListByID(lID) // TODO: Get the list with one query by item ID
if err != nil {
return
}
if !list.CanWrite(&user) {
return ErrNeedToBeListWriter{ListID: i.ListID, UserID: user.ID}
}
// Check if we have at least a text
if i.Text == "" {
return ErrListItemCannotBeEmpty{}
@ -55,3 +46,25 @@ func createOrUpdateListItem(i *ListItem, doer *User, lID int64) (err error) {
return
}
// This helper function checks if the user has the right to edit a list item.
// It is used in Create/Update/Delete.
func listItemPreCheck(i *ListItem, doer *User, lID int64) (user User, err error) {
// Check rights
user, _, err = GetUserByID(doer.ID)
if err != nil {
return
}
// Get the list to check if the user has the right to write to that list
list, err := GetListByID(lID) // TODO: Get the list with one query by item ID
if err != nil {
return
}
if !list.CanWrite(&user) {
return user, ErrNeedToBeListWriter{ListID: i.ListID, UserID: user.ID}
}
return
}