ami/tl-vikunja
1
0
Fork 0
Code

feat: remove props destructuring from ProjectKanban

Browse Source
This commit is contained in:
Dominik Pschenitschni 2024-07-05 15:14:25 +02:00 committed by konrad
parent 449e9a911c
commit 5af908b2e5
1 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
frontend/src/components/project/views/ProjectKanban.vue
View File

@ -308,10 +308,7 @@ import ProjectViewModel from '@/models/projectView'
import TaskBucketService from '@/services/taskBucket' import TaskBucketService from '@/services/taskBucket'
import TaskBucketModel from '@/models/taskBucket' import TaskBucketModel from '@/models/taskBucket'
const { const props = defineProps<{
projectId,
viewId,
} = defineProps<{
projectId: number, projectId: number,
viewId: IProjectView['id'], viewId: IProjectView['id'],
}>() }>()
@ -391,8 +388,8 @@ const bucketDraggableComponentData = computed(() => ({
{'dragging-disabled': !canWrite.value}, {'dragging-disabled': !canWrite.value},
], ],
})) }))
const project = computed(() => projectId ? projectStore.projects[projectId] : null) const project = computed(() => props.projectId ? projectStore.projects[props.projectId] : null)
const view = computed<IProjectView | null>(() => project.value?.views.find(v => v.id === viewId) || null) const view = computed(() => project.value?.views.find(v => v.id === props.viewId) as IProjectView || null)
const canWrite = computed(() => baseStore.currentProject?.maxRight > Rights.READ && view.value.bucketConfigurationMode === 'manual') const canWrite = computed(() => baseStore.currentProject?.maxRight > Rights.READ && view.value.bucketConfigurationMode === 'manual')
const buckets = computed(() => kanbanStore.buckets) const buckets = computed(() => kanbanStore.buckets)
const loading = computed(() => kanbanStore.isLoading) const loading = computed(() => kanbanStore.isLoading)
@ -402,10 +399,10 @@ const taskLoading = computed(() => taskStore.isLoading || taskPositionService.va
watch( watch(
() => ({ () => ({
params: params.value, params: params.value,
projectId, projectId: props.projectId,
viewId, viewId: props.viewId,
}), }),
({params}) => { ({params, projectId, viewId}) => {
if (projectId === undefined || Number(projectId) === 0) { if (projectId === undefined || Number(projectId) === 0) {
return return
} }
@ -434,8 +431,8 @@ function handleTaskContainerScroll(id: IBucket['id'], el: HTMLElement) {
} }
kanbanStore.loadNextTasksForBucket( kanbanStore.loadNextTasksForBucket(
projectId, props.projectId,
viewId, props.viewId,
params.value, params.value,
id, id,
) )
@ -509,7 +506,7 @@ async function updateTaskPosition(e) {
try { try {
const newPosition = new TaskPositionModel({ const newPosition = new TaskPositionModel({
position, position,
projectViewId: viewId, projectViewId: props.viewId,
taskId: newTask.id, taskId: newTask.id,
}) })
await taskPositionService.value.update(newPosition) await taskPositionService.value.update(newPosition)
@ -518,7 +515,7 @@ async function updateTaskPosition(e) {
const updatedTaskBucket = await taskBucketService.value.update(new TaskBucketModel({ const updatedTaskBucket = await taskBucketService.value.update(new TaskBucketModel({
taskId: newTask.id, taskId: newTask.id,
bucketId: newTask.bucketId, bucketId: newTask.bucketId,
projectViewId: viewId, projectViewId: props.viewId,
projectId: project.value.id, projectId: project.value.id,
})) }))
newTask.done = updatedTaskBucket.taskDone newTask.done = updatedTaskBucket.taskDone
@ -586,7 +583,7 @@ async function createNewBucket() {
await kanbanStore.createBucket(new BucketModel({ await kanbanStore.createBucket(new BucketModel({
title: newBucketTitle.value, title: newBucketTitle.value,
projectId: project.value.id, projectId: project.value.id,
projectViewId: viewId, projectViewId: props.viewId,
})) }))
newBucketTitle.value = '' newBucketTitle.value = ''
} }
@ -606,7 +603,7 @@ async function deleteBucket() {
bucket: new BucketModel({ bucket: new BucketModel({
id: bucketToDelete.value, id: bucketToDelete.value,
projectId: project.value.id, projectId: project.value.id,
projectViewId: viewId, projectViewId: props.viewId,
}), }),
params: params.value, params: params.value,
}) })
@ -635,7 +632,7 @@ async function saveBucketTitle(bucketId: IBucket['id'], bucketTitle: string) {
await kanbanStore.updateBucket({ await kanbanStore.updateBucket({
id: bucketId, id: bucketId,
title: bucketTitle, title: bucketTitle,
projectId, projectId: props.projectId,
}) })
success({message: i18n.global.t('project.kanban.bucketTitleSavedSuccess')}) success({message: i18n.global.t('project.kanban.bucketTitleSavedSuccess')})
bucketTitleEditable.value = false bucketTitleEditable.value = false
@ -657,7 +654,7 @@ function updateBucketPosition(e: { newIndex: number }) {
kanbanStore.updateBucket({ kanbanStore.updateBucket({
id: bucket.id, id: bucket.id,
projectId, projectId: props.projectId,
position: calculateItemPosition( position: calculateItemPosition(
bucketBefore !== null ? bucketBefore.position : null, bucketBefore !== null ? bucketBefore.position : null,
bucketAfter !== null ? bucketAfter.position : null, bucketAfter !== null ? bucketAfter.position : null,
@ -672,7 +669,7 @@ async function saveBucketLimit(bucketId: IBucket['id'], limit: number) {
await kanbanStore.updateBucket({ await kanbanStore.updateBucket({
...kanbanStore.getBucketById(bucketId), ...kanbanStore.getBucketById(bucketId),
projectId, projectId: props.projectId,
limit, limit,
}) })
success({message: t('project.kanban.bucketLimitSavedSuccess')}) success({message: t('project.kanban.bucketLimitSavedSuccess')})