1
0

Refactored canRead method to get the list before checking the right (#65)

This commit is contained in:
konrad
2019-03-24 13:17:36 +00:00
committed by Gitea
parent 47352d3ed4
commit 5525ee0328
7 changed files with 15 additions and 16 deletions

View File

@ -69,7 +69,6 @@ func (l *Label) hasAccessToLabel(a web.Auth) (bool, error) {
Where("label_task.label_id != null OR labels.created_by_id = ?", u.ID).
Or(builder.In("label_task.task_id", taskIDs)).
And("labels.id = ?", l.ID).
GroupBy("labels.id").
Exist(&labels)
return has, err
}

View File

@ -45,8 +45,9 @@ func (l *List) CanRead(a web.Auth) (bool, error) {
user := getUserForRights(a)
// Check if the user is either owner or can read
// We can do this without first looking up the list because CanRead() is called after ReadOne()
// So are sure the list exists
if err := l.GetSimpleByID(); err != nil {
return false, err
}
if l.isOwner(user) {
return true, nil
}