From 4b9b9da122a2d085dcff8fbb8dd2693062689fd4 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <mail@celement.de>
Date: Fri, 5 Jul 2024 15:56:15 +0200
Subject: [PATCH] feat: use withDefaults for ReminderPeriod

---
 .../tasks/partials/ReminderPeriod.vue           | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/tasks/partials/ReminderPeriod.vue b/frontend/src/components/tasks/partials/ReminderPeriod.vue
index 8a6cd06eb..b669517ac 100644
--- a/frontend/src/components/tasks/partials/ReminderPeriod.vue
+++ b/frontend/src/components/tasks/partials/ReminderPeriod.vue
@@ -73,13 +73,13 @@ import TaskReminderModel from '@/models/taskReminder'
 import type {ITaskReminder} from '@/modelTypes/ITaskReminder'
 import {type IReminderPeriodRelativeTo, REMINDER_PERIOD_RELATIVE_TO_TYPES} from '@/types/IReminderPeriodRelativeTo'
 
-const {
-	modelValue,
-} = defineProps<{
-	modelValue?: ITaskReminder,
+const props = defineProps<{
+	modelValue: ITaskReminder,
 }>()
 
-const emit = defineEmits(['update:modelValue'])
+const emit = defineEmits<{
+	'update:modelValue': [ITaskReminder]
+}>()
 
 const reminder = ref<ITaskReminder>(new TaskReminderModel())
 
@@ -98,14 +98,17 @@ const period = ref<PeriodInput>({
 })
 
 watch(
-	() => modelValue,
+	() => props.modelValue,
 	(value) => {
 		const p = secondsToPeriod(value?.relativePeriod)
 		period.value.durationUnit = p.unit
 		period.value.duration = Math.abs(p.amount)
 		period.value.relativeTo = value?.relativeTo || REMINDER_PERIOD_RELATIVE_TO_TYPES.DUEDATE
 	},
-	{immediate: true},
+	{
+		immediate: true,
+		deep: true,
+	},
 )
 
 watch(