feat: don't rethrow same error and handle errors globally

src/store/modules/auth.js

@@ -159,9 +159,6 @@ export default {
 					ctx.dispatch('checkAuth')
 					return Promise.resolve()
 				})
-				.catch(e => {
-					return Promise.reject(e)
-				})
 				.finally(() => {
 					ctx.commit(LOADING, false, {root: true})
 				})
@@ -174,9 +171,7 @@ export default {
 				.then(r => {
 					saveToken(r.data.token, false)
 					ctx.dispatch('checkAuth')
-					return Promise.resolve(r.data)
-				}).catch(e => {
-					return Promise.reject(e)
+					return r.data
 				})
 		},
 		// Populates user information from jwt token saved in local storage in store
@@ -238,7 +233,7 @@ export default {
 					ctx.commit('lastUserRefresh')
 				})
 				.catch(e => {
-					console.error('Error while refreshing user info:', e)
+					throw new Error('Error while refreshing user info:', { cause: e })
 				})
 		},
 		// Renews the api token and saves it to local storage

src/store/modules/config.js

@@ -68,7 +68,6 @@ export default {
 					ctx.commit(CONFIG, r.data)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 		},
 		redirectToProviderIfNothingElseIsEnabled(ctx) {
 			if (ctx.state.auth.local.enabled === false &&

src/store/modules/kanban.js

@@ -222,14 +222,9 @@ export default {
 				.then(r => {
 					ctx.commit('setBuckets', r)
 					ctx.commit('setListId', listId)
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
-				})
-				.finally(() => {
-					cancel()
+					return r
 				})
+				.finally(() => cancel())
 		},
 
 		loadNextTasksForBucket(ctx, {listId, ps = {}, bucketId}) {
@@ -282,10 +277,7 @@ export default {
 					if (taskService.totalPages <= page) {
 						ctx.commit('setAllTasksLoadedForBucket', bucketId)
 					}
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 				.finally(() => {
 					cancel()
@@ -300,14 +292,9 @@ export default {
 			return bucketService.create(bucket)
 				.then(r => {
 					ctx.commit('addBucket', r)
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
-				})
-				.finally(() => {
-					cancel()
+					return r
 				})
+				.finally(() => cancel())
 		},
 
 		deleteBucket(ctx, {bucket, params}) {
@@ -319,14 +306,9 @@ export default {
 					ctx.commit('removeBucket', bucket)
 					// We reload all buckets because tasks are being moved from the deleted bucket
 					ctx.dispatch('loadBucketsForList', {listId: bucket.listId, params: params})
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
-				})
-				.finally(() => {
-					cancel()
+					return r
 				})
+				.finally(() => cancel())
 		},
 
 		updateBucket(ctx, updatedBucketData) {

src/store/modules/labels.js

@@ -91,7 +91,6 @@ export default {
 					ctx.commit('setLoaded', true)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 		deleteLabel(ctx, label) {
@@ -103,7 +102,6 @@ export default {
 					ctx.commit('removeLabelById', label)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 		updateLabel(ctx, label) {
@@ -115,7 +113,6 @@ export default {
 					ctx.commit('setLabel', r)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 		createLabel(ctx, label) {
@@ -127,7 +124,6 @@ export default {
 					ctx.commit('setLabel', r)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 	},

src/store/modules/lists.js

@@ -53,7 +53,6 @@ export default {
 					ctx.commit('setList', r)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 		updateList(ctx, list) {
@@ -99,10 +98,7 @@ export default {
 					ctx.commit('removeListById', list)
 					ctx.commit('namespaces/removeListFromNamespaceById', list, {root: true})
 					removeListFromHistory({id: list.id})
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 				.finally(() => cancel())
 		},

src/store/modules/namespaces.js

@@ -115,7 +115,6 @@ export default {
 
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => {
 					cancel()
 				})
@@ -141,7 +140,6 @@ export default {
 					ctx.commit('removeNamespaceById', namespace.id)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 		createNamespace(ctx, namespace) {
@@ -153,7 +151,6 @@ export default {
 					ctx.commit('addNamespace', r)
 					return Promise.resolve(r)
 				})
-				.catch(e => Promise.reject(e))
 				.finally(() => cancel())
 		},
 	},

src/store/modules/tasks.js

@@ -45,7 +45,6 @@ function addLabelToTask(task, label) {
 			task.labels.push(label)
 			return Promise.resolve(result)
 		})
-		.catch(e => Promise.reject(e))
 }
 
 function findAssignees(parsedTaskAssignees) {
@@ -77,9 +76,6 @@ export default {
 					ctx.commit(HAS_TASKS, r.length > 0, {root: true})
 					return r
 				})
-				.catch(e => {
-					return Promise.reject(e)
-				})
 				.finally(() => {
 					cancel()
 				})
@@ -92,10 +88,7 @@ export default {
 			return taskService.update(task)
 				.then(t => {
 					ctx.commit('kanban/setTaskInBucket', t, {root: true})
-					return Promise.resolve(t)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return t
 				})
 				.finally(() => {
 					cancel()
@@ -106,10 +99,7 @@ export default {
 			return taskService.delete(task)
 				.then(t => {
 					ctx.commit('kanban/removeTaskInBucket', task, {root: true})
-					return Promise.resolve(t)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return t
 				})
 		},
 		// Adds a task attachment in store.
@@ -151,10 +141,7 @@ export default {
 					// FIXME: direct store manipulation (task)
 					t.task.assignees.push(user)
 					ctx.commit('kanban/setTaskInBucketByIndex', t, {root: true})
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 		},
 		removeAssignee(ctx, {user, taskId}) {
@@ -182,10 +169,7 @@ export default {
 					}
 
 					ctx.commit('kanban/setTaskInBucketByIndex', t, {root: true})
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 
 		},
@@ -208,10 +192,7 @@ export default {
 					t.task.labels.push(label)
 					ctx.commit('kanban/setTaskInBucketByIndex', t, {root: true})
 
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 		},
 
@@ -241,10 +222,7 @@ export default {
 
 					ctx.commit('kanban/setTaskInBucketByIndex', t, {root: true})
 
-					return Promise.resolve(r)
-				})
-				.catch(e => {
-					return Promise.reject(e)
+					return r
 				})
 		},
 
@@ -296,7 +274,7 @@ export default {
 			
 			//  4. If none of the above worked, reject the promise with an error.
 			if (typeof foundListId === 'undefined' || listId === null) {
-				return Promise.reject('NO_LIST')
+				throw new Error('NO_LIST')
 			}
 		
 			return foundListId
@@ -336,7 +314,6 @@ export default {
 					task,
 					parsedLabels:parsedTask.labels,
 				}))
-				.catch(e => Promise.reject(e))
 		},
 	},
 }