ami/tl-vikunja
1
0
Fork 0
Code

feat(kanban): set task position to 0 (top) when it is moved into the done bucket automatically after marking it done

Browse Source
This commit is contained in:
kolaente 2024-04-06 14:35:05 +02:00
parent 1cd5dd2b2f
commit 2f6b395334
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/models/tasks.go
View File

@ -672,9 +672,21 @@ func setTaskBucket(s *xorm.Session, task *Task, originalTask *Task, view *Projec
return return
} }
// If the task was marked as done and the view has a done bucket, move the task to the done bucket
if task.Done && originalTask != nil && if task.Done && originalTask != nil &&
(!originalTask.Done || task.ProjectID != originalTask.ProjectID) { (!originalTask.Done || task.ProjectID != originalTask.ProjectID) {
targetBucket.BucketID = view.DoneBucketID targetBucket.BucketID = view.DoneBucketID
// …and also reset the position so that it shows up at the top
// Note: this might result in an "off-looking" position when there is already a task with position 0.
// This is done by design, because recalculating all positions is really costly and will happen
// later anyway.
_, err = s.
Where("task_id = ? AND project_view_id = ?", task.ID, view.ID).
Cols("position").
Update(&TaskPosition{Position: 0})
if err != nil {
return
}
} }
if targetBucket.BucketID == 0 && oldTaskBucket.BucketID != 0 { if targetBucket.BucketID == 0 && oldTaskBucket.BucketID != 0 {