From 29dcc02217dfe9d52b3cdd6166ca82cc8be1022e Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Thu, 21 Jul 2022 00:34:42 +0200
Subject: [PATCH] feat: handle changing props

---
 src/components/tasks/gantt-chart.vue | 13 +++++++++++--
 src/views/list/ListGantt.vue         |  5 +++--
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/components/tasks/gantt-chart.vue b/src/components/tasks/gantt-chart.vue
index da201ffea..b87aecf2e 100644
--- a/src/components/tasks/gantt-chart.vue
+++ b/src/components/tasks/gantt-chart.vue
@@ -53,7 +53,7 @@
 </template>
 
 <script setup lang="ts">
-import {computed, nextTick, ref} from 'vue'
+import {computed, nextTick, ref, watch} from 'vue'
 import TaskCollectionService from '@/services/taskCollection'
 import {format, parse} from 'date-fns'
 import {colorIsDark} from '@/helpers/color/colorIsDark'
@@ -85,6 +85,11 @@ const props = defineProps({
 		type: String,
 		required: true,
 	},
+	showTasksWithoutDates: {
+		type: Boolean,
+		required: false,
+		default: false,
+	},
 })
 
 const dateFromDate = computed(() => parse(props.dateFrom, 'yyyy-LL-dd', new Date()))
@@ -142,7 +147,7 @@ async function loadTasks() {
 		filter_comparator: ['greater_equals', 'less_equals'],
 		filter_value: [props.dateFrom, props.dateTo],
 		filter_concat: 'and',
-		filter_include_nulls: true,
+		filter_include_nulls: props.showTasksWithoutDates,
 	}
 
 	const taskCollectionService = new TaskCollectionService()
@@ -168,6 +173,10 @@ async function loadTasks() {
 
 loadTasks()
 
+watch(() => props.dateTo, loadTasks)
+watch(() => props.dateFrom, loadTasks)
+watch(() => props.showTasksWithoutDates, loadTasks)
+
 async function updateTask(e) {
 	const task = tasks.value.get(e.bar.ganttBarConfig.id)
 	task.startDate = e.bar.startDate
diff --git a/src/views/list/ListGantt.vue b/src/views/list/ListGantt.vue
index bdbaeff2f..63ed5af34 100644
--- a/src/views/list/ListGantt.vue
+++ b/src/views/list/ListGantt.vue
@@ -28,7 +28,7 @@
 							</div>
 						</div>
 					</div>
-					<fancycheckbox class="is-block" v-model="showTaskswithoutDates">
+					<fancycheckbox class="is-block" v-model="showTasksWithoutDates">
 						{{ $t('list.gantt.showTasksWithoutDates') }}
 					</fancycheckbox>
 				</div>
@@ -44,6 +44,7 @@
 						:date-to="dateTo"
 						:precision="precision"
 						:list-id="props.listId"
+						:show-tasks-without-dates="showTasksWithoutDates"
 					/>
 
 				</card>
@@ -71,7 +72,7 @@ const props = defineProps({
 	},
 })
 
-const showTaskswithoutDates = ref(false)
+const showTasksWithoutDates = ref(false)
 const precision = ref('day')
 
 const now = ref(new Date())