ami/tl-vikunja
1
0
Fork 0
Code

fix: make computed side-effect free

Browse Source
This commit is contained in:
kolaente 2023-03-28 21:31:38 +02:00
parent c32a198a34
commit 26bec05174
No known key found for this signature in database
GPG Key ID: F40E70337AB24C9B
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/views/tasks/TaskDetailView.vue
View File

@ -450,7 +450,7 @@
</template> </template>
<script lang="ts" setup> <script lang="ts" setup>
import {ref, reactive, toRef, shallowReactive, computed, watch, nextTick, type PropType} from 'vue' import {ref, reactive, toRef, shallowReactive, computed, watch, watchEffect, nextTick, type PropType} from 'vue'
import {useRouter, type RouteLocation} from 'vue-router' import {useRouter, type RouteLocation} from 'vue-router'
import {useI18n} from 'vue-i18n' import {useI18n} from 'vue-i18n'
import {unrefElement} from '@vueuse/core' import {unrefElement} from '@vueuse/core'
@ -539,16 +539,11 @@ const visible = ref(false)
const taskId = toRef(props, 'taskId') const taskId = toRef(props, 'taskId')
const project = computed(() => { const project = computed(() => task.projectId ? projectStore.getProjectById(task.projectId) : null)
if (!task.projectId) { watchEffect(() => {
return { baseStore.handleSetCurrentProject({
project: null, project: project.value,
} })
}
const project = projectStore.getProjectById(task.projectId)
baseStore.handleSetCurrentProject({project})
return project
}) })
const canWrite = computed(() => ( const canWrite = computed(() => (