From 1de39b1cd1bb3ea1ad62b86c46b7b0472a7e3ccd Mon Sep 17 00:00:00 2001
From: kolaente <k@knt.li>
Date: Wed, 13 Mar 2024 18:16:18 +0100
Subject: [PATCH] fix(quick actions): do not allow creating a task when the
 current project is a saved filter

Resolves https://community.vikunja.io/t/creating-task-on-saved-filter-page-doesnt-save/2127
---
 .../components/quick-actions/quick-actions.vue | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/quick-actions/quick-actions.vue b/frontend/src/components/quick-actions/quick-actions.vue
index 46e47dd80..3779d0c5a 100644
--- a/frontend/src/components/quick-actions/quick-actions.vue
+++ b/frontend/src/components/quick-actions/quick-actions.vue
@@ -85,7 +85,7 @@
 </template>
 
 <script setup lang="ts">
-import {ref, computed, watchEffect, shallowReactive, type ComponentPublicInstance} from 'vue'
+import {type ComponentPublicInstance, computed, ref, shallowReactive, watchEffect} from 'vue'
 import {useI18n} from 'vue-i18n'
 import {useRouter} from 'vue-router'
 
@@ -107,13 +107,14 @@ import {useTaskStore} from '@/stores/tasks'
 import {useAuthStore} from '@/stores/auth'
 
 import {getHistory} from '@/modules/projectHistory'
-import {parseTaskText, PrefixMode, PREFIXES} from '@/modules/parseTaskText'
+import {parseTaskText, PREFIXES, PrefixMode} from '@/modules/parseTaskText'
 import {success} from '@/message'
 
 import type {ITeam} from '@/modelTypes/ITeam'
 import type {ITask} from '@/modelTypes/ITask'
 import type {IProject} from '@/modelTypes/IProject'
 import type {IAbstract} from '@/modelTypes/IAbstract'
+import {isSavedFilter} from '@/services/savedFilter'
 
 const {t} = useI18n({useScope: 'global'})
 const router = useRouter()
@@ -280,10 +281,13 @@ const commands = computed<{ [key in COMMAND_TYPE]: Command }>(() => ({
 
 const placeholder = computed(() => selectedCmd.value?.placeholder || t('quickActions.placeholder'))
 
-const currentProject = computed(() => Object.keys(baseStore.currentProject).length === 0
-	? null
-	: baseStore.currentProject,
-)
+const currentProject = computed(() => {
+	if (Object.keys(baseStore.currentProject).length === 0 || isSavedFilter(baseStore.currentProject)) {
+		return null
+	}
+	
+	return baseStore.currentProject
+})
 
 const hintText = computed(() => {
 	if (selectedCmd.value !== null && currentProject.value !== null) {
@@ -372,7 +376,7 @@ function searchTasks() {
 	const {text, project: projectName, labels} = parsedQuery.value
 
 	let filter = ''
-	
+
 	if (projectName !== null) {
 		const project = projectStore.findProjectByExactname(projectName)
 		console.log({project})