Fix lint errs (#59)

pkg/models/bulk_list_task.go

@@ -109,7 +109,7 @@ func (bt *BulkTask) Update() (err error) {
 		}
 
 		// And because a false is considered to be a null value, we need to explicitly check that case here.
-		if bt.ListTask.Done == false {
+		if !bt.ListTask.Done {
 			oldtask.Done = false
 		}
 

pkg/models/label_task.go

@@ -204,10 +204,8 @@ func (t *ListTask) updateTaskLabels(creator web.Auth, labels []*Label) (err erro
 
 	// Make a hashmap of the new labels for easier comparison
 	newLabels := make(map[int64]*Label, len(labels))
-	var allLabelIDs []int64
 	for _, newLabel := range labels {
 		newLabels[newLabel.ID] = newLabel
-		allLabelIDs = append(allLabelIDs, newLabel.ID)
 	}
 
 	// Get old labels to delete

pkg/models/list.go

@@ -58,12 +58,12 @@ func GetListsByNamespaceID(nID int64, doer *User) (lists []*List, err error) {
 			Or("ul.user_id = ?", doer.ID).
 			GroupBy("l.id").
 			Find(&lists)
-		if err != nil {
-			return nil, err
-		}
 	} else {
 		err = x.Where("namespace_id = ?", nID).Find(&lists)
 	}
+	if err != nil {
+		return nil, err
+	}
 
 	// get more list details
 	err = AddListDetails(lists)

pkg/models/list_tasks_create_update.go

@@ -129,7 +129,7 @@ func (t *ListTask) Update() (err error) {
 	}
 
 	// And because a false is considered to be a null value, we need to explicitly check that case here.
-	if t.Done == false {
+	if !t.Done {
 		ot.Done = false
 	}
 

pkg/models/models.go

@@ -95,7 +95,7 @@ func init() {
 func SetEngine() (err error) {
 	x, err = getEngine()
 	if err != nil {
-		return fmt.Errorf("Failed to connect to database: %v", err)
+		return fmt.Errorf("failed to connect to database: %v", err)
 	}
 
 	// Cache
@@ -104,13 +104,11 @@ func SetEngine() (err error) {
 		case "memory":
 			cacher := xorm.NewLRUCacher(xorm.NewMemoryStore(), viper.GetInt("cache.maxelementsize"))
 			x.SetDefaultCacher(cacher)
-			break
 		case "redis":
 			cacher := xrc.NewRedisCacher(viper.GetString("redis.host"), viper.GetString("redis.password"), xrc.DEFAULT_EXPIRATION, x.Logger())
 			x.SetDefaultCacher(cacher)
 			gob.Register(tables)
 			gob.Register(tablesWithPointer) // Need to register tables with pointer as well...
-			break
 		default:
 			log.Log.Info("Did not find a valid cache type. Caching disabled. Please refer to the docs for poosible cache types.")
 		}

pkg/models/namespace_delete.go

@@ -49,6 +49,9 @@ func (n *Namespace) Delete() (err error) {
 
 	// Delete all lists with their tasks
 	lists, err := GetListsByNamespaceID(n.ID, &User{})
+	if err != nil {
+		return
+	}
 	var listIDs []int64
 	// We need to do that for here because we need the list ids to delete two times:
 	// 1) to delete the lists itself

pkg/models/team_members_create.go

@@ -49,6 +49,9 @@ func (tm *TeamMember) Create(a web.Auth) (err error) {
 	// Check if that user is already part of the team
 	exists, err := x.Where("team_id = ? AND user_id = ?", tm.TeamID, tm.UserID).
 		Get(&TeamMember{})
+	if err != nil {
+		return
+	}
 	if exists {
 		return ErrUserIsMemberOfTeam{tm.TeamID, tm.UserID}
 	}

pkg/models/teams_test.go

@@ -98,8 +98,7 @@ func TestIsErrInvalidRight(t *testing.T) {
 	assert.NoError(t, RightWrite.isValid())
 
 	// Check invalid
-	var tr Right
-	tr = 938
+	var tr Right = 938
 	err := tr.isValid()
 	assert.Error(t, err)
 	assert.True(t, IsErrInvalidRight(err))