1
0

feat: formatting

- remove unneeded data props
- prepare for compiler warnings vue3; see https://v3.vuejs.org/guide/migration/v-bind.html
This commit is contained in:
Dominik Pschenitschni
2021-09-08 11:59:46 +02:00
committed by kolaente
parent 4454e6cf22
commit 0da7a46612
15 changed files with 30 additions and 38 deletions

View File

@ -11,9 +11,7 @@
<navigation/>
<div
:class="[
{
'is-menu-enabled': menuActive,
},
{ 'is-menu-enabled': menuActive },
$route.name,
]"
class="app-content"
@ -58,10 +56,6 @@ export default {
this.loadLabels()
},
computed: mapState({
namespaces(state) {
return state.namespaces.namespaces.filter(n => !n.isArchived)
},
currentList: CURRENT_LIST,
background: 'background',
menuActive: MENU_ACTIVE,
userInfo: state => state.auth.info,

View File

@ -83,12 +83,12 @@
triggered by the change needs to have access to the current namespace
-->
<draggable
v-bind="dragOptions"
:value="activeLists[nk]"
@input="(lists) => updateActiveLists(n, lists)"
:group="`namespace-${n.id}-lists`"
@start="() => drag = true"
@end="e => saveListPosition(e, nk)"
v-bind="dragOptions"
handle=".handle"
:disabled="n.id < 0"
:class="{'dragging-disabled': n.id < 0}"

View File

@ -47,8 +47,6 @@ export default {
}
img {
-webkit-border-radius: 100%;
-moz-border-radius: 100%;
border-radius: 100%;
vertical-align: middle;

View File

@ -54,6 +54,8 @@ import names from '@/models/constants/notificationNames.json'
import {closeWhenClickedOutside} from '@/helpers/closeWhenClickedOutside'
import {mapState} from 'vuex'
const LOAD_NOTIFICATIONS_INTERVAL = 10000
export default {
name: 'notifications',
components: {User},
@ -71,7 +73,7 @@ export default {
mounted() {
this.loadNotifications()
document.addEventListener('click', this.hidePopup)
this.interval = setInterval(this.loadNotifications, 10000)
this.interval = setInterval(this.loadNotifications, LOAD_NOTIFICATIONS_INTERVAL)
},
beforeDestroy() {
document.removeEventListener('click', this.hidePopup)

View File

@ -196,7 +196,6 @@ export default {
return {
linkShares: [],
linkShareService: LinkShareService,
newLinkShare: LinkShareModel,
rights: rights,
selectedRight: rights.READ,
name: '',
@ -277,9 +276,7 @@ export default {
this.showDeleteModal = false
})
},
copy(text) {
copy(text)
},
copy,
getShareLink(hash) {
return this.frontendUrl + 'share/' + hash + '/auth'
},

View File

@ -56,7 +56,7 @@
</span>
<span
class="has-text-success"
v-if="
v-else-if="
!taskCommentService.loading &&
saved === c.id
"

View File

@ -10,7 +10,7 @@
<span class="loader is-inline-block mr-2"></span>
{{ $t('misc.saving') }}
</span>
<span class="is-small has-text-success" v-if="!loading && saved">
<span class="is-small has-text-success" v-else-if="!loading && saved">
<icon icon="check"/>
{{ $t('misc.saved') }}
</span>

View File

@ -1,8 +1,6 @@
<template>
<div class="heading">
<h1 class="title task-id">
{{ task.getTextIdentifier && task.getTextIdentifier() ? task.getTextIdentifier() : '' }}
</h1>
<h1 class="title task-id">{{ textIdentifier }}</h1>
<div class="is-done" v-if="task.done">Done</div>
<h1
class="title input"
@ -11,13 +9,16 @@
@keydown.enter.prevent.stop="$event.target.blur()"
:contenteditable="canWrite ? 'true' : 'false'"
spellcheck="false"
ref="taskTitle">{{ task.title.trim() }}</h1>
ref="taskTitle"
>
{{ task.title.trim() }}
</h1>
<transition name="fade">
<span class="is-inline-flex is-align-items-center" v-if="loading && saving">
<span class="loader is-inline-block mr-2"></span>
{{ $t('misc.saving') }}
</span>
<span class="has-text-success is-inline-flex is-align-content-center" v-if="!loading && showSavedMessage">
<span class="has-text-success is-inline-flex is-align-content-center" v-else-if="!loading && showSavedMessage">
<icon icon="check" class="mr-2"/>
{{ $t('misc.saved') }}
</span>
@ -41,6 +42,9 @@ export default {
task() {
return this.value
},
textIdentifier() {
return this.task?.getTextIdentifier() || ''
},
},
props: {
value: {

View File

@ -19,7 +19,7 @@
<span class="loader is-inline-block mr-2"></span>
{{ $t('misc.saving') }}
</span>
<span class="has-text-success" v-if="!taskRelationService.loading && saved">
<span class="has-text-success" v-else-if="!taskRelationService.loading && saved">
{{ $t('misc.saved') }}
</span>
</transition>